<Swing Dev> JDK 9 RFR of JDK-8075082: Fix missing doclint warnings in the javax.swing package
Anton V. Tarasov
anton.tarasov at oracle.com
Wed Apr 15 15:14:44 UTC 2015
Hi Joe,
(Looking into DefaultFocusManager.java)
Formally, the @return description is not good here:
+ /**
+ * Compare the components.
+ * @param a the first component
+ * @param b the second component
+ * @return the result of comparing the components
+ */
public boolean compareTabOrder(Component a, Component b) {
return (comparator.compare(a, b) < 0);
}
because not the components are compared for equality but their order in a focus traversal cycle.
(Also, just a remark. The swing's FocusManager and DefaultFocusManager classes are obsolete since
JDK 1.4, they're not used any longer actually.)
Regards,
Anton.
On 14.04.2015 21:02, Sergey Bylokhov wrote:
> HI, Joe.
> The fix looks good. But it will be good if Anton(CC) will take a look to the documentation of
> DefaultFocusManager.java
>
> On 10.04.15 4:22, joe darcy wrote:
>> ping
>>
>> Any comments or objections to this fix?
>>
>> -Joe
>>
>> On 4/7/2015 2:32 PM, joe darcy wrote:
>>> Hello,
>>>
>>> Please review changes to address
>>>
>>> JDK-8075082: Fix missing doclint warnings in the javax.swing package
>>> http://cr.openjdk.java.net/~darcy/8075082.0/
>>>
>>> Thanks,
>>>
>>> -Joe
>>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150415/01213001/attachment.html>
More information about the swing-dev
mailing list