<Swing Dev> [9] Review Request for 7072653: JComboBox popup mispositioned if its height exceeds the screen height

Semyon Sadetsky semyon.sadetsky at oracle.com
Thu Apr 16 13:14:22 UTC 2015


Subject corrected.

On 4/16/2015 3:55 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-7072653
> webrev: http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.00/
>
> *THE ROOT CAUSE
> Incorrect bounds calculation of heavy weight popup window in the 
> BasicComboPopup when the requested popup menu height exceeds screen 
> height.
> Additional issue found: popup border thickness is not taken into 
> account when popup direction switched to up as the result popup 
> overlaps its combo-box by 2 pixels.
> Also in multi-monitor desktop if screen are arranged vertically popup 
> can be shown on another monitor.
>
> *SOLUTION
> The popup location algorithm is corrected to take into account the 
> current screen height and border insets.
>
> *TESTING
> Test is added to ensure popup window height when combo-box contains 
> 1000 items.
>
> --Semyon
>




More information about the swing-dev mailing list