<Swing Dev> [9] Review request for 8051548 JColorChooser should have a way to disable transparency controls

Phil Race philip.race at oracle.com
Thu Apr 16 20:27:27 UTC 2015


  210
  211     void setColorTransparencySelectionEnabled(boolean b) {
  212         spinners[model.getCount() - 1].setVisible(b);
  213         colorChanged();
  214     }

do you want to check if there's a state change here before firing the 
events ?

Other than that it looks OK to me.

-phil.

On 4/16/15 1:14 AM, Alexandr Scherbatiy wrote:
> 15.04.2015 22:22, Sergey Bylokhov пишет:
>> HI, Alexander.
>> What is the status of this fix?
>
> The fix requires at least two reviewers.
>
> Thanks,
> Alexandr.
>
>>
>> On 25.07.14 16:45, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8051548
>>> webrev: http://cr.openjdk.java.net/~alexsch/8051548/webrev.00
>>>
>>> The following public methods are added to the 
>>> AbstractColorChooserPanel:
>>> - setColorTransparencySelectionEnabled(boolean b)
>>> - isColorTransparencySelectionEnabled()
>>>
>>> The request to the public API change will be created after the 
>>> technical review.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
>




More information about the swing-dev mailing list