<Swing Dev> [9] request for review: 8073001: Java's system LnF on OS X: editable JComboBoxes are being rendered incorrectly

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Apr 27 11:52:34 UTC 2015


Hi, Andrew.
The fix looks fine.

On 23.04.15 18:23, Andrew Brygin wrote:
> Hello,
>
>  could you please review a fix for CR 8073001?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8073001
> Webrev: http://cr.openjdk.java.net/~bae/8073001/9/webrev.00/
>
>  To resolve the problem with combobox rendering, suggested fix
>  adjusts text border insets in order to match dimension of the
>  arrow button.
>
>  Also, it unifies focus handling in order to get the arrow button
>  updated both for cases of standard and custom editors.
>  Supplied regression test verifies that the arrow button is
>  updated correctly.
>
>  Please take a look.
>
> Thanks,
> Andrew.


-- 
Best regards, Sergey.




More information about the swing-dev mailing list