<Swing Dev> [9] Review Request for 8078483: Apparent endless loop running JEditorPanePaintTest

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Apr 27 12:32:51 UTC 2015


Hi, Semyon.
The fix looks fine.
ps Actually the failed test is not a regresison test so please mark the 
CR as noreg-sqe. Probably sqe can port some of these tests, which  not 
requere the base jdk? (***FunctionalPaintTest.java)

On 27.04.15 9:03, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8078483/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8078483
>
> ***ROOT CASE
> Text component root view should receive the component dimension 
> without margins.
> The caret margin introduced in 
> https://bugs.openjdk.java.net/browse/JDK-6866751 fix was not taken 
> into account.
>
> ***SOLUTION
> Extract caret margin from the dimension width.
>
> ***TESTING
> No extra test is needed. This is a reg test failure issue.
>
> --Semyon
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150427/b5387973/attachment.html>


More information about the swing-dev mailing list