<Swing Dev> [9] Review request for 8031109 Rendering HTML code in JEditorPane throws NumberFormatException

[Alexander Zvegintsev]

Hello Victor,

It seems that there are 2 uncovered cases:
1) 120PX looks like a valid case to me, so we could use toLowerCase() here.
2) The space handling after a number is missing for absolute and 
relative cases (e.g. "120 px", "2      *").
However percent case is covered by parseDigits() call. We can reuse 
parseDigits() function  or just trim a string after asterisk or PX removing.

--
Thanks,
Alexander.

On 27.04.2015 18:56, Victor D'yakov wrote:
> Hello,
>
> Please review the fix for JDK9:
> bug: https://bugs.openjdk.java.net/browse/JDK-8031109
> webrev link: 
> http://cr.openjdk.java.net/~alexsch/victor-dyakov/8031109/webrev.00/
> Root Cause:
>     FrameSetView does not parse "px" units in rows and cols attributes.
> Solution:
>     "px" are parsed in the FrameSetView.init() method.
> Testing:
>     Run test/javax/swing/text/html/8031109/bug8031109.java automated 
> test.
>
> -- 
> Victor
>