<Swing Dev> [9] Review request for 8031109 Rendering HTML code in JEditorPane throws NumberFormatException

[Alexander Zvegintsev]

the fix looks good to me.

Thanks,
Alexander.

On 28/04/15 17:25, Victor D'yakov wrote:
> Hi Alexander,
>
> Thanks for next iteration. This is updated webrev:
> http://cr.openjdk.java.net/~alexsch/victor-dyakov/8031109/webrev.02/
>
> Also added possible case of input like "10 *" and "2 2".
> The test is updated too.
>
> -- 
> Victor
>
> On 28.04.2015 16:24, Alexander Zvegintsev wrote:
>> Hi Victor,
>>
>> The absolute case part looks good to me,
>> but relative case part(for input like "2  *") is still missing a trim:
>>
>>  127                     relativeChildren[i] =
>>  128 Integer.parseInt(children[i].substring(
>>  129                             0, children[i].length()-1));
>>
>>
>> -- 
>> Thanks,
>> Alexander.
>>
>> On 28.04.2015 14:57, Victor D'yakov wrote:
>>> Hi Alexander,
>>>
>>> Thanks for the review. This is updated webrev:
>>> http://cr.openjdk.java.net/~alexsch/victor-dyakov/8031109/webrev.01/
>>>
>>> -- 
>>> Victor
>>>
>>> On 27.04.2015 21:43, Alexander Zvegintsev wrote:
>>>> Hello Victor,
>>>>
>>>> It seems that there are 2 uncovered cases:
>>>> 1) 120PX looks like a valid case to me, so we could use 
>>>> toLowerCase() here.
>>>> 2) The space handling after a number is missing for absolute and 
>>>> relative cases (e.g. "120 px", "2      *").
>>>> However percent case is covered by parseDigits() call. We can reuse 
>>>> parseDigits() function  or just trim a string after asterisk or PX 
>>>> removing.
>>>>
>>>> -- 
>>>> Thanks,
>>>> Alexander.
>>>>
>>>> On 27.04.2015 18:56, Victor D'yakov wrote:
>>>>> Hello,
>>>>>
>>>>> Please review the fix for JDK9:
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8031109
>>>>> webrev link: 
>>>>> http://cr.openjdk.java.net/~alexsch/victor-dyakov/8031109/webrev.00/
>>>>> Root Cause:
>>>>>     FrameSetView does not parse "px" units in rows and cols 
>>>>> attributes.
>>>>> Solution:
>>>>>     "px" are parsed in the FrameSetView.init() method.
>>>>> Testing:
>>>>>     Run test/javax/swing/text/html/8031109/bug8031109.java 
>>>>> automated test.
>>>>>
>>>>> -- 
>>>>> Victor
>>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>>
>