<Swing Dev> [9] request for review: 8073001: Java's system LnF on OS X: editable JComboBoxes are being rendered incorrectly

[Andrew Brygin]

Hello Alexander,

  suggested way also works fine. Please take a look to updated fix:

http://cr.openjdk.java.net/~bae/8073001/9/webrev.01/

Thanks,
Andrew

On 4/27/2015 5:13 PM, Alexander Potochkin wrote:
> Hello Andrew
>
> Can we update the existing focusListener class
> created in AquaComboBoxUI.createFocusListener() method
>
> and add there
>
> if (arrowButton != null) {
>                  arrowButton.repaint();
> }
>
> to re use the methods configure/unconfigureEditor methods from the 
> base class?
>
> Thanks
> alexp
>
> On 4/23/2015 6:23 PM, Andrew Brygin wrote:
>> Hello,
>>
>>  could you please review a fix for CR 8073001?
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8073001
>> Webrev: http://cr.openjdk.java.net/~bae/8073001/9/webrev.00/
>>
>>  To resolve the problem with combobox rendering, suggested fix
>>  adjusts text border insets in order to match dimension of the
>>  arrow button.
>>
>>  Also, it unifies focus handling in order to get the arrow button
>>  updated both for cases of standard and custom editors.
>>  Supplied regression test verifies that the arrow button is
>>  updated correctly.
>>
>>  Please take a look.
>>
>> Thanks,
>> Andrew.
>