<Swing Dev> [9] Review request for 8078614 WindowsClassicLookAndFeel : MetalComboBoxUI.getbaseLine fails with IllegalArgumentException

[Sergey Bylokhov]

Hi, Victor.
The fix looks good.

On 28.04.15 18:33, Victor D'yakov wrote:
> Hi Sergey,
>
> Thanks for review. This is updated webrev which contains updated test:
> http://cr.openjdk.java.net/~alexsch/victor-dyakov/8078614/webrev.01/
>
> -- 
> Victor
>
> On 28.04.2015 17:27, Sergey Bylokhov wrote:
>> Hi, Victor.
>> A few notes:
>>  - import of com.sun.java.swing.plaf.windows.WindowsComboBoxUI is 
>> unnecessary and should be removed.
>>  - The test should use invokeAndWait, otherwise it can successfully 
>> complete, when the main method exits before exception will be 
>> generated on EDT.
>>
>> On 27.04.15 18:44, Victor D'yakov wrote:
>>> Hello,
>>>
>>> Please review the fix for JDK9:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078614
>>> webrev link: 
>>> http://cr.openjdk.java.net/~alexsch/victor-dyakov/8078614/webrev.00/
>>> Root Cause:
>>>     The case where the height can be less than insets top+bottom is 
>>> not checked.
>>> Solution:
>>>     Return 0 for case where the height is less than insets top+bottom.
>>> Testing:
>>>     Run test/javax/swing/JComboBox/6632953/bug6632953.java automated 
>>> test.
>>>
>>> -- 
>>> Victor
>>
>>
>


-- 
Best regards, Sergey.