<Swing Dev> [RFR JDK-8017187] [TEST BUG] [macosx] After click "test", the case failed automatically with thrown exception in the log since jdk8b75

[Alexander Scherbatiy]

On 8/11/2015 2:24 PM, nadeesh tv wrote:
>
> Hi,
>
> Please review the updated webrev links
> closed - http://cr.openjdk.java.net/~sgupta/8017187/webrev.01/
> open -  http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/

   Some comments:
    - copyright should be added to the test
    - it needs to use SwingUtilities.invokeAndWait() in the tests 
instead of invokeLater() because JTreg can just finish the test and 
report it as passed before EDT can even start
    - could you put each new webrev in a separate  directory so it would 
be possible to look at the previous versions

  Thanks,
  Alexandr.

> Thanks and Regards,
> Nadeesh TV
>
>
> On 8/6/2015 8:13 PM, nadeesh tv wrote:
>> Hi,
>> Please review the updated webrev links
>> closed - http://cr.openjdk.java.net/~sgupta/8017187/webrev.01/
>> open -  http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/
>>
>> Thanks and Regards,
>> Nadeesh TV
>> On 8/5/2015 9:04 PM, Alexander Scherbatiy wrote:
>>> On 8/5/2015 5:05 PM, nadeesh tv wrote:
>>>> HI all,
>>>> Please review the updated webrev links
>>>> closed - http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/
>>>> open - http://cr.openjdk.java.net/~sgupta/8017187/webrev.01/
>>>     - the patch does not contain the html file as it expected but it 
>>> still is shown on the provided open link. It seems that the 
>>> index.html file has not been updated.
>>>     - the swing calls like "!menu.isSelected()" should be invoked on 
>>> EDT.
>>>
>>>   Thanks,
>>>   Alexandr.
>>>> Thanks and Regards,
>>>> Nadeesh TV
>>>>
>>>> On 7/29/2015 3:38 PM, Alexander Scherbatiy wrote:
>>>>>
>>>>>  - It looks like the html file has been used only because the test 
>>>>> was manual and it can be simply removed.
>>>>>  - Is it possible to use a robot to press keys rather than put 
>>>>> KeyEvents directly to the SystemEventQueue?
>>>>>
>>>>>  Thanks,
>>>>>  Alexandr.
>>>>>
>>>>>
>>>>> On 7/24/2015 9:13 PM, nadeesh tv wrote:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> Please review a test bug fix
>>>>>>
>>>>>> TEST : *closed/javax/swing/JMenu/4213634/bug4213634.java *
>>>>>> BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8017187*
>>>>>>
>>>>>> Please*move  the test from closed repo tom open repo*.
>>>>>>
>>>>>>
>>>>>> The webrev 
>>>>>> is:http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/ add to 
>>>>>> open repo
>>>>>>
>>>>>>
>>>>>> http://cr.openjdk.java.net/~kshefov/8017187/webrev.diff/ - diff 
>>>>>> with previous version of the  closed test.
>>>>>>
>>>>>> -- 
>>>>>> Thanks and Regards,
>>>>>> Nadeesh TV
>>>>>>
>>>>>
>>>>
>>>
>>
>