<Swing Dev> Bug : JDK-8078831 Mismatch of getPreferredSize() and getPreferredScrollableViewportSize() values in WindowsClassicLookAndFeel

[Rajeev Chamyal]

Hi All,

Please review the following webrev.

http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.open/
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.closed/

Test has been moved to open repository.

Regards,
Rajeev Chamyal

-----Original Message-----
From: Alexander Scherbatiy 
Sent: Thursday, August 27, 2015 5:46 PM
To: Rajeev Chamyal
Cc: Alexander Zvegintsev; Sergey Bylokhov; swing-dev at openjdk.java.net
Subject: Re: Bug : JDK-8078831 Mismatch of getPreferredSize() and getPreferredScrollableViewportSize() values in WindowsClassicLookAndFeel

On 8/27/2015 1:34 PM, Rajeev Chamyal wrote:
> Hello All,
>
> Please review the updated fix with latest review comments.
>
> http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.01/

    This looks better.

    Please, move it to the open repository, add copyright and properly format the code:
       Java Code Conventions: 
http://www.oracle.com/technetwork/java/codeconventions-150003.pdf
       new discussed Java Style Guidelines: 
http://cr.openjdk.java.net/~alundblad/styleguide

   Thanks,
   Alexandr.

>
> Regards,
> Rajeev Chamyal
>
> -----Original Message-----
> From: Alexander Scherbatiy
> Sent: Wednesday, August 26, 2015 6:42 PM
> To: Rajeev Chamyal
> Cc: Alexander Zvegintsev; Sergey Bylokhov; swing-dev at openjdk.java.net
> Subject: Re: Bug : JDK-8078831 Mismatch of getPreferredSize() and 
> getPreferredScrollableViewportSize() values in 
> WindowsClassicLookAndFeel
>
> On 8/26/2015 12:13 PM, Rajeev Chamyal wrote:
>> Hi,
>>
>> Please review the following fix for jdk9:
>>    
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8078831
>>
>> Webrev :
>> http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.00/
>> <http://cr.openjdk.java.net/%7Epsadhukhan/rajeev/5042886/webrev.00/>
>>
>> getPreferredScrollableViewportSize() must not return the same as getPreferredSize() but it should return equal or less size. Test condition was checking for inequality and throwing Runtime exception.
>>    
>      Please, split lines which are longer than 80 characters.
>
>     Thanks,
>     Alexandr.
>
>> Regards,
>> Rajeev Chamyal
>>