<Swing Dev> Review Request for 8139169: Action registered for keyboard shortcut is called twice

[Alexander Scherbatiy]

On 08/12/15 08:08, Avik Niyogi wrote:
> Hi All,
>
> Please find the updated web rev.02 with inputs provided below. Small 
> minor change as suggested was inserted. Please commit the change if 
> acceptable now. Thank you.
> http://cr.openjdk.java.net/~aniyogi/8139169/webrev.02/ 
> <http://cr.openjdk.java.net/%7Eaniyogi/8139169/webrev.02/>

    Is it necessary to check the UCKeyTranslate function for the 
paramErr return value?

   Thanks,
   Alexandr.
>
> With Regards,
> Avik Niyogi
>
>> On 07-Dec-2015, at 9:27 pm, Sergey Bylokhov 
>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>
>> Hi, Avik.
>> The fix looks fine for me.
>>
>> But I think that you incorrectly tried to place the window in the 
>> center of the screen, you need to place 
>> frame.setLocationRelativeTo(null); after call to setSize().
>>
>> On 03.12.15 8:26, Avik Niyogi wrote:
>>> Hi All,
>>>
>>> Please find updated webrev.01 with inputs from comments below:
>>> http://cr.openjdk.java.net/~aniyogi/8139169/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Eaniyogi/8139169/webrev.01/>
>>>
>>> With Regards,
>>> Avik Niyogi
>>>> On 02-Dec-2015, at 5:16 pm, Rajeev Chamyal 
>>>> <rajeev.chamyal at oracle.com <mailto:rajeev.chamyal at oracle.com>
>>>> <mailto:rajeev.chamyal at oracle.com>> wrote:
>>>>
>>>> Hello Avik,
>>>> Can you use @requires (os.family == "mac") instead of a method to
>>>> check the OS type.
>>>> Regards,
>>>> Rajeev Chamyal
>>>> *From:*Avik Niyogi
>>>> *Sent:*30 November 2015 17:22
>>>> *To:*Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov;
>>>> swing-dev at openjdk.java.net 
>>>> <mailto:swing-dev at openjdk.java.net><mailto:swing-dev at openjdk.java.net>
>>>> *Subject:*<Swing Dev> Review Request for 8139169: Action registered
>>>> for keyboard shortcut is called twice
>>>> Hi All,
>>>> Kindly review the fix for JDK9.
>>>> *Bug*:
>>>> https://bugs.openjdk.java.net/browse/JDK-8139169
>>>> *Webrev*:
>>>> http://cr.openjdk.java.net/~aniyogi/8139169/webrev.00/
>>>> *Issue*: Swing action with an accelerator like "meta shift COMMA”.
>>>> It is put in the component's action map, when it is invoked, the
>>>> action is called twice.
>>>> *Cause*: Incorrect implementation within CMenuItem.m
>>>> *Fix*:Added logic to sense all modifiers including “shift” in
>>>> CMenuItem which did not exist before.
>>>> With Regards,
>>>> Avik Niyogi
>>>
>>
>>
>> --
>> Best regards, Sergey.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20151209/902d4902/attachment.html>