<Swing Dev> Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

[Sergey Bylokhov]

Hi, Avik.
Looks fine to me. It seems that the cast here is not necessary?
if (o != (ComponentOrientation) e.getOldValue())

Can you confirm that this bug not affectes our other looks and feels? It 
will be good to update the test to prove that.

On 17/12/15 10:21, Avik Niyogi wrote:
>
>
> Hi All,
>
> Kindly review the fix for JDK9.
> *Bug*: https://bugs.openjdk.java.net/browse/JDK-8041894
> <https://bugs.openjdk.java.net/browse/JDK-7124218>
>
> *Webrev*: http://cr.openjdk.java.net/~aniyogi/8041894/webrev.00/
>
> *Issue*: Test case throws an exception as subcomponents of were not
> getting orientation
>   property assignment.
>
> *Cause*: The case where property name as Component orientation not
> present to traverse
> the property to subcomponents of spinner for Aqua look and feel.
>
> *Fix*: The else if clause for this property name was added while
> checking for for editor to
> take charge of applying the component orientation to all subsequent
> subcomponents.
>
> With Regards,
> Avik Niyogi


-- 
Best regards, Sergey.