<Swing Dev> Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Avik Niyogi avik.niyogi at oracle.com
Mon Dec 21 11:55:27 UTC 2015


Hi All,

Kindly review the bug fix for JDK 9.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8016665 <https://bugs.openjdk.java.net/browse/JDK-8016665>

Webrev:
http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/ <http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/>

Issue:
The manual test: Swing_AllComponents/Manual/I18nSwingTests
in testsuite http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing <http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing> fails.

Cause:
Due to not honouring of RIGHT_TO_LEFT parameter for setOrientation method applied for a JFileChooser for the AquaLookAndFeel only,
the fileChooser does not get displayed in RIGHT_TO_LEFT orientation. 
This issue was verified to exist only in AquaLookAndFeel for JFileChooser only due to wrong implementation in AquaFileSystemModel.
Also, as provided in comments: "The Aqua LAF must support the RTL orientation of JFileChooser."

Fix:
Added implementation for the check of RIGHT_TO_LEFT ComponentOrientation and verified with test suite.


With Regards,
Avik Niyogi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20151221/c0d4b71b/attachment.html>


More information about the swing-dev mailing list