<Swing Dev> Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it

[Sergey Bylokhov]

On 28/12/15 10:45, Rajeev Chamyal wrote:
> Hello Sergey,
>
> Thanks for the review. I have updated the code.
> http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/

This patch has some additional changes.

>
> Regards,
> Rajeev Chamyal
>
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: 25 December 2015 21:23
> To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev at openjdk.java.net
> Subject: Re: Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it
>
> Hi, Rajeev.
> I guess "d.setComponentOrderCheckingEnabled(false);" should be moved also for consistency.
>
> On 14/12/15 08:32, Rajeev Chamyal wrote:
>> Hello All,
>>
>> Please review the following fix for Jdk9:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145060
>>
>> Webrev:http://cr.openjdk.java.net/~rchamyal/8145060/webrev.00/
>>
>> Issue: On minimizing the successive internal frames the focus is not
>> shifting to frame below it.
>>
>> Cause: During minimize internal frame is removed from container.
>> Removal of internal frames from container also removes the internal
>> frame entry from internal frame cache.
>>
>> During focus shift cache is checked for current internal frame entry
>> and then focus is shifted to frame below it. As removal from container
>> has already updated the cache so
>>
>> Current frame is not found in cache and focus shift fails.
>>
>> Fix: Internal frame removal from container is done after focus shift.
>>
>> Regards,
>>
>> Rajeev Chamyal
>>
>
>
> --
> Best regards, Sergey.
>


-- 
Best regards, Sergey.