<Swing Dev> [9] Review Request: 6573305 Animated icon is not visible by click on menu

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Jan 13 10:34:13 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 1/12/2015 9:11 PM, Sergey Bylokhov wrote:
> Hello.
> Please review a fix for jdk 9.
> When we paint some image on component we use this component as an 
> observer, which will be called when the image should be repainted(in 
> case of animated gif for example). But our code in the 
> AbstractButton.imageUpdate() will replace correct Icon to null if 
> button is pressed, disabled, etc(if such icon was not set of course). 
> After the fix we will use default icon only if more specific image was 
> not found.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6573305
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/6573305/webrev.00
>




More information about the swing-dev mailing list