<Swing Dev> [9] Review request for 8068040 [macosx] Combo box consuming ENTER key events

[Alexander Zvegintsev]

Hello Alexander,

the fix looks good to me.

Thanks,

Alexander.

On 01/13/2015 06:10 PM, Sergey Bylokhov wrote:
> Hi, Alexander.
> The fix looks good.
>
> On 13.01.2015 17:06, Alexander Scherbatiy wrote:
>>
>> Could you review the updated fix:
>>   http://cr.openjdk.java.net/~alexsch/8068040/webrev.01/
>>
>>   The "aquaEnterPressed" is renamed to "enterPressed" in 
>> AquaComboBoxUI and AquaKeyBindings clases.
>>
>>  Thanks,
>>  Alexandr.
>>
>> On 1/12/2015 6:02 PM, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8068040
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8068040/webrev.00
>>>
>>>   BasicComboBoxUI has a special workaround to forward the enter 
>>> pressed event
>>>   on the editable combo box to the default button. The combobox 
>>> editor handler quires the "enterPressed" action
>>>   and executes it.
>>>
>>>   AquaComboBoxUI registers the enter action only with the 
>>> "aquaEnterPressed" key.
>>>
>>>   The possible solutions are:
>>>   - BasicComboBoxUI could use L&F dependent key for an enter action. 
>>> It may require adding some public API.
>>>   - Register a new handler to the comboboc editor. The 
>>> actionPerformed method of this handler will duplicate
>>>     Handler code from BasicComboBoxUI.
>>>
>>>   The proposed solution just registers the AquaComboBoxUI enter 
>>> action with the "enterPressed" key.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>
>