<Swing Dev> [9] Review Request: 6459798 JDesktopPane, JFileChooser violate encapsulation by returning internal Dimensions

[Alexander Zvegintsev]

I think so, it looks good to me.

--
Thanks,
Alexander.

On 20.01.2015 21:45, Sergey Bylokhov wrote:
> Hi, Alexander.
> On 20.01.2015 20:42, Alexander Zvegintsev wrote:
>> I think that we should left GTKFileChooserUI.java as it is. Old 
>> version has all magic numbers in one place.
>> So probably MotifFileChooserUI.java should be modified to new 
>> Dimension(MIN_SIZE) also.
>
> Then, probably, will be better to store them like other l&fs?
> http://cr.openjdk.java.net/~serb/6459798/webrev.01
>
>>
>> Otherwise it looks good to me.
>>
>> Thanks,
>>
>> Alexander.
>>
>> On 01/20/2015 08:07 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for jdk 9.
>>> Defensive copies were added where necessary.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6459798
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/6459798/webrev.00
>>>
>>> -- 
>>> Best regards, Sergey.
>>>
>>
>
>