<Swing Dev> [9-client] Review request for bug 8068301 : [TEST_BUG] Test javax/swing/JColorChooser/Test4177735.java fails with ArrayIndexOutOfBoundsException with GTKL&F

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Jan 28 14:26:55 UTC 2015


On 1/26/2015 6:57 PM, shobhit gupta wrote:
> Hi Alexandr,
>
> Updated webrev link : 
> http://cr.openjdk.java.net/~kshefov/8068301/webrev.03/

   The code formatting requires spaces in variable assignments, 'for' 
and 'if' statements.
   You can get any IDE and use code format option.

   Thanks,
   Alexandr.

>
> Thanks and Regards,
> Shobhit Gupta
>
> On 23-Jan-15 7:57 PM, Alexander Scherbatiy wrote:
>>
>> Could you format the code according to the Java code conventions:
>> http://www.oracle.com/technetwork/java/codeconvtoc-136057.html
>>
>> Thanks,
>> Alexandr.
>>
>> On 1/22/2015 12:39 PM, shobhit gupta wrote:
>>> Earlier link is pointing to the other webrev.
>>> Updated webrev link : 
>>> http://cr.openjdk.java.net/~kshefov/8068301/webrev.02/
>>>
>>> Regards,
>>> Shobhit Gupta
>>> On 22-Jan-15 3:05 PM, shobhit gupta wrote:
>>>> |Hi,|
>>>> |Please review a fix ||for| |the issue:|
>>>>
>>>> 8068301 : [TEST_BUG] Test 
>>>> javax/swing/JColorChooser/Test4177735.java fails with 
>>>> ArrayIndexOutOfBoundsException with GTKL&F
>>>> |Test bug fix.|
>>>> |https://bugs.openjdk.java.net/browse/JDK-8068301|||
>>>> |The webrev is: 
>>>> |http://cr.openjdk.java.net/~kshefov/8068301/webrev.02/||
>>>>
>>>> ws used : http://hg.openjdk.java.net/jdk9/client/jdk
>>>>
>>>> |Thanks & Regards,
>>>> |
>>>> |Shobhit Gupta|
>>>
>>
>




More information about the swing-dev mailing list