<Swing Dev> [9] Review Request for 8129940: JRadioButton does not honor non-standard FocusTraversalKeys

[Alexander Scherbatiy]

On 7/2/2015 3:53 PM, Semyon Sadetsky wrote:
> Hi Alexander,
>
> 1. It seems bug8075609.java is wrong . Tab key should not move focus 
> to the next option in the group.
> 2. I have changed the if-statement to the shortcut you've proposed:

    The fix looks good for me.

    Assuming that the new version is: 
http://cr.openjdk.java.net/~ssadetsky/8129940/webrev.01/

    Thanks,
    Alexandr.

>
> --Semyon
>
> On 7/2/2015 3:13 PM, Alexander Scherbatiy wrote:
>>
>>  - Could you look at the test 
>> javax/swing/JRadioButton/8075609/bug8075609.java
>>    It fails on my Windows system even without your fix 
>> (RuntimeException: Focus is not on textField as Expected).
>>    If it does not relate to the fix area we can create a separate 
>> issue to it.
>>
>>  - The 'if' statement on the line 609  can be simplified to return 
>> keys != null && keys.contains(stroke)
>>
>>  Thanks,
>>  Alexandr.
>>
>> On 6/26/2015 4:22 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8129940
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8129940/webrev.00/
>>>
>>> It is a regression from 8033699. In this fix focus traversal keys 
>>> were hard-coded in JRadioButton to be TAB and SHIFT+TAB only. But 
>>> those keys can be amended by user as well. Solution : use the 
>>> generic logic to identify focus traversal keys.
>>>
>>> --Semyon
>>
>