<Swing Dev> [9] Review Request for 8076164: [JTextField] When input too long Thai character, cursor's behavior is odd

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Jul 7 09:20:05 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 7/7/2015 10:10 AM, Semyon Sadetsky wrote:
> Hi Alexander,
>
> Since the component is initialized only and is not added to any window 
> the EDT is not really necessary.
> Anyway I added it and also took into account your other comments here: 
> http://cr.openjdk.java.net/~ssadetsky/8076164/webrev.01/
>
> --Semyon
>
> On 6/30/2015 4:24 PM, Alexander Scherbatiy wrote:
>>
>>   The fix looks good to me.
>>
>>   Just update the copyright in the test, use Swing component on EDT 
>> and format the code.
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 6/25/2015 5:27 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8076164
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8076164/webrev.00/
>>>
>>> It is a regression from 6973777. In 6973777 GlyphView minimum span 
>>> with calculation was changed to use text wrapping into several 
>>> lines. That was necessary to fix several JTextPane scenarios. But 
>>> this change did not preserve the generic rule: if resizing is 
>>> disabled in getResizeWeight() then the preferred size should be used 
>>> as the minimum. Since originally the GlyphView was not resizable the 
>>> fix broke JTextFiled's I18N view because text wrapping is not 
>>> applicable to it by design.
>>> The solution restores the logic for JTextFiled's I18N content view.
>>>
>>> --Semyon
>>>
>>
>




More information about the swing-dev mailing list