<Swing Dev> [9] Review Request for 8075785: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with the special options "-client -Dswing.defaultlaf=com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel".

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Jul 13 12:21:33 UTC 2015


Hi, Semyon.
The fix looks fine.

On 01.06.15 11:49, Semyon Sadetsky wrote:
> Hi Sergey,
>
> As per our offline discussion:  we cannot avoid the "instance-of" 
> chain even if we add new properties to the default table. So the 
> advantage of the proposed change: it is minimalistic and does not 
> change the initial design.
>
> --Semyon
>
> On 5/29/2015 1:24 PM, Sergey Bylokhov wrote:
>> Hi, Semyon.
>> Why not set this properties in the look and feel to the same color as 
>> "Button.shadow" and use it WindowsGraphicsUtils?
>>
>> On 28.05.15 18:29, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8075785
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8075785/webrev.00/
>>>
>>> *.disabledText properties are not suported in in Windows Classic L&F 
>>> & Windows XP L&F.
>>> In the fix the properties remain optional but are taken into account 
>>> if set by user.
>>>
>>> --Semyon
>>
>>
>


-- 
Best regards, Sergey.




More information about the swing-dev mailing list