<Swing Dev> [9] Review request for 8087110: [TESTBUG] Test javax/swing/JFileChooser/8002077/bug8002077.java fails

[Alexander Scherbatiy]

  The fix looks good to me.

  Thanks,
  Alexandr.

On 7/9/2015 6:38 PM, Alexey Ivanov wrote:
> Hi Sergey,
>
> Thank you for your review. Yes, mnemonic was removed because Enter can 
> be used to "click" Save button, see JDK-5035693. Yet testing that 
> Enter "clicks" Save button should be done in another test if it 
> doesn't exist.
>
> At the same time, I modified the test so that it tests whether the 
> original issue in JDK-8002077 is reproduced or not.
>
> The updated webrev: 
> http://cr.openjdk.java.net/~aivanov/8087110/jdk9/webrev.01/
>
> The bug was that changing from open dialog (default) to save dialog 
> didn't update mnemonic on the approve button. I added mnemonics to 
> Open and Save buttons in UIManager. This updated test passes 
> successfully now, and it fails on a build without JDK-8002077 fix.
>
> This way the test still does its job.
>
>
> Thanks,
> Alexey
>
> On 16.06.2015 21:42, Sergey Bylokhov wrote:
>> Probably we can check that mnemonic does not work, and after that 
>> check that the enter actually works? I recall that mnemonic was 
>> removed because enter is a default key anyway?
>>
>> On 16.06.15 19:01, Alexander Scherbatiy wrote:
>>>
>>>   The fix looks good to me.
>>>
>>>   Thanks,
>>>   Alexandr.
>>>
>>> On 6/15/2015 4:32 PM, Alexey Ivanov wrote:
>>>> Hello Swing team,
>>>>
>>>> Could you please review the fix:
>>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8087110
>>>>     webrev: 
>>>> http://cr.openjdk.java.net/~aivanov/8087110/jdk9/webrev.00/
>>>>
>>>> Description:
>>>> This test fails because Save button in JFileChooser has no mnemonic 
>>>> after the fix for JDK-8080628.
>>>> So the test javax/swing/JFileChooser/8002077/bug8002077.java has 
>>>> become redundant and I'm removing it.
>>>>
>>>> Thanks,
>>>> Alexey
>>>
>>
>>
>