<Swing Dev> [8u-dev] Review request for 8087110: [TESTBUG] Test javax/swing/JFileChooser/8002077/bug8002077.java fails

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Jul 16 11:36:01 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 7/16/2015 1:29 PM, Alexey Ivanov wrote:
> Hello Swing team,
>
> Could you please review the backport of JDK-8087110 to jdk8u-dev:
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8087110
>     webrev: http://cr.openjdk.java.net/~aivanov/8087110/jdk8/webrev.00/
>
>     jdk9 webrev: 
> http://cr.openjdk.java.net/~aivanov/8087110/jdk9/webrev.01/
>     jdk9 review thread:
> http://mail.openjdk.java.net/pipermail/swing-dev/2015-June/004599.html
> http://mail.openjdk.java.net/pipermail/swing-dev/2015-July/004640.html
>     jdk9 changeset: 
> http://hg.openjdk.java.net/jdk9/client/jdk/rev/ebdeb89e5dfb
>
> The changes in JDK 8 are the same as in JDK 9, however the patch does 
> not apply cleanly because JDK 9 uses Robot.waitForIdle() whereas JDK 8 
> uses SunToolkit.realSync().
>
> Description:
> I modified the failing test by adding mnemonics to Open and Save 
> buttons via UIManager.
> The test passes successfully now, and it fails on a build without 
> JDK-8002077 fix.
>
> Thanks,
> Alexey




More information about the swing-dev mailing list