<Swing Dev> [9] Review Request for 8130892: Test javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java fails in Solaris Sparcv9

Semyon Sadetsky semyon.sadetsky at oracle.com
Thu Jul 23 06:22:11 UTC 2015


O.K. It sounds like a generic rule. Can I add this constant to the 
Component.reshape()?

--Semyon

On 7/22/2015 3:40 PM, Sergey Bylokhov wrote:
> It seems that the bug is in fact that the size of the window is 
> negative. In a lot of place we assume that it should be >=0.
>
> On 22.07.15 14:28, Semyon Sadetsky wrote:
>> In setVisible(true) if size is not specified and pack has not been 
>> called yet frame get some initial size depending on the platform.
>> That is the purpose of the test : to call pack() after setVisible().
>>
>> --Semyon
>>
>> On 7/22/2015 2:03 PM, Alexander Scherbatiy wrote:
>>> On 7/17/2015 5:32 PM, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> Please review fix for JDK9:
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8130892
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8130892/webrev.00/
>>>>
>>>> On Linux and Solaris platforms the initial frame window width and 
>>>> height can be negative. So the root view is initialization trigger 
>>>> was updated to take negative values into account. The fix was 
>>>> tested on Ubuntu 12, OEL7 and Solaris 11.
>>>    It looks strange that the test which does not set explicit bounds 
>>> and calls frame.pack() encounters into negative sizes.
>>>    In which place does the frame window obtain negative width and 
>>> height?
>>>
>>>    Thanks,
>>>    Alexandr.
>>>
>>>>
>>>> --Semyon
>>>
>>
>
>




More information about the swing-dev mailing list