<Swing Dev> < Swing Dev> [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

[Alexander Scherbatiy]

   The fix looks good to me.

   Thanks,
   Alexandr.

On 7/29/2015 10:00 AM, pooja chopra wrote:
> Hi ,
> As default look and feel in mac is aqua only so there is no need of 
> setting system look and feel explicitly.
>
> Please review updated webrev link below:-
>
> 8081764  [TEST_BUG] Test 
> javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris 
> Sparcv9 and Linux but passes on MacOSX
> Test bug fix.
> https://bugs.openjdk.java.net/browse/JDK-8081764
> The webrev is : http://cr.openjdk.java.net/~pchopra/8081764/webrev.01/
>
> Regards,
> Pooja
>
> On 6/11/2015 2:23 PM, pooja chopra wrote:
>> Hi Andrew ,
>> The test  passes with GTKLookAndFeel on Solaris but with out 
>> GTKLookAndFeel test fails with same error as mentioned in the bug . I 
>> had explicitly set the look and feel as system look and feel as test 
>> was to be run for Mac only and this test was placed in plaf/aqua and 
>> it is comparing screenshots so I thought in other look and feel there 
>> can be a possibility  that this matching fails. Please let me know if 
>> some changes are required .
>> Regards,
>> Pooja
>> On 6/9/2015 1:15 PM, Andrew Brygin wrote:
>>> Hello Pooja,
>>>
>>>  In general I tend to agree with idea to limit the scope of the test 
>>> by macosx only.
>>>
>>>  However, could you please clarify following questions:
>>> a) the test failure on linux/solaris: doesn't it indicate a similar 
>>> problem with gtk laf, does it?
>>> b) what is purpose of the explicit LaF setup (lines 68 - 69)?
>>>
>>> Thanks,
>>> Andrew
>>>
>>> On 6/8/2015 12:59 PM, pooja chopra wrote:
>>>> Hi All,
>>>> Correcting the webrev link below . Please review below fix .
>>>> Regards,
>>>> Pooja
>>>> On 6/8/2015 3:27 PM, pooja chopra wrote:
>>>>> Hello,
>>>>>
>>>>> Please review a fix for issue :-
>>>>> 8081764  [TEST_BUG] Test 
>>>>> javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on 
>>>>> Solaris Sparcv9 and Linux but passes on MacOSX
>>>>> Test bug fix.
>>>>> https://bugs.openjdk.java.net/browse/JDK-8081764
>>>>> The webrev is : http://cr.openjdk.java.net/~pchopra/8081764/webrev.00
>>>>>
>>>>> Regards,
>>>>> Pooja
>>>>>
>>>>
>>>
>>
>