<Swing Dev> [9] Review Request for 8129838: NPE in java.awt.Choice

[Alexander Scherbatiy]

  The fix looks good to me.

  Thanks,
  Alexandr.

On 7/30/2015 9:22 AM, Semyon Sadetsky wrote:
> Hi Alexander,
>
> - I have introduced a private method for those 2 duplicated lines 
> you've found.
> - One iteration will require to rework the initial logic.
>
> http://cr.openjdk.java.net/~ssadetsky/8129838/webrev.01/
>
> --Semyon
>
>
> On 7/29/2015 2:39 PM, Alexander Scherbatiy wrote:
>>
>>   - Could you move the duplicated code to one method?
>>   - Is it possible to find bounds using only one iteration over 
>> GraphicsDevice/GraphicsConfiguration loop.
>>
>>  Thanks,
>>  Alexandr.
>>
>> On 7/29/2015 12:51 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8129838
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8129838/webrev.00/
>>>
>>> This regression from 7072653. Swing components used as AWT 
>>> components peers in OSX do not receive graphics configuration so NPE 
>>> is thrown.  The solution is to obtain it directly from the graphics 
>>> environment.
>>>
>>> --Semyon
>>>
>>
>