<Swing Dev> [9] Review Request for 8132136: [PIT] RTL orientation in JEditorPane is broken

[Sergey Bylokhov]

Looks fine, thanks.

On 30.07.15 11:47, Semyon Sadetsky wrote:
> I have added test case.
>
> http://cr.openjdk.java.net/~ssadetsky/8132136/webrev.01/
>
> --Semyon
>
> On 7/24/2015 7:24 PM, Sergey Bylokhov wrote:
>> The fix looks fine. But please provide the test case for it. The test 
>> which found the bug compare screenshots between the base and tested 
>> jdk. And the bug can be skipped in case of wrong base build 
>> selection. I guess small test unit will better cover the issue.
>>
>> On 24.07.15 11:00, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8132136
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8132136/webrev.00/
>>>
>>> A regression from JDK-8076164. GlyphView should be unrealizable by 
>>> default not only for JTextFiled i18n view (as it was assumed in 
>>> 8076164 fix).
>>> So the solution is to remove the specific BasicTextFieldUI and make 
>>> GlyphView.getMinimumSize() returns non-resizeable value by default.
>>>
>>> --Semyon
>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.