From semyon.sadetsky at oracle.com  Mon Jun  1 08:49:49 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Mon, 01 Jun 2015 11:49:49 +0300
Subject: <Swing Dev> [9] Review Request for 8075785: The
 regression-swing case failed as colored text is not shown on disabled
 checkbox and radio button with the special options "-client
 -Dswing.defaultlaf=com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel".
In-Reply-To: <55683E5D.1080901@oracle.com>
References: <55673455.30202@oracle.com> <55683E5D.1080901@oracle.com>
Message-ID: <556C1CAD.5000308@oracle.com>

Hi Sergey,

As per our offline discussion:  we cannot avoid the "instance-of" chain 
even if we add new properties to the default table. So the advantage of 
the proposed change: it is minimalistic and does not change the initial 
design.

--Semyon

On 5/29/2015 1:24 PM, Sergey Bylokhov wrote:
> Hi, Semyon.
> Why not set this properties in the look and feel to the same color as 
> "Button.shadow" and use it WindowsGraphicsUtils?
>
> On 28.05.15 18:29, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8075785
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8075785/webrev.00/
>>
>> *.disabledText properties are not suported in in Windows Classic L&F 
>> & Windows XP L&F.
>> In the fix the properties remain optional but are taken into account 
>> if set by user.
>>
>> --Semyon
>
>



From shobhit.s.gupta at oracle.com  Tue Jun  2 05:13:28 2015
From: shobhit.s.gupta at oracle.com (shobhit gupta)
Date: Tue, 02 Jun 2015 10:43:28 +0530
Subject: <Swing Dev> [9-dev] Review request for bug 8079450 : [TESTBUG]
 javax/swing/plaf/nimbus/8041642/bug8041642.java fails
Message-ID: <556D3B78.7040102@oracle.com>

Hi,

Please review a fix for the issue:

8079450 : [TESTBUG] javax/swing/plaf/nimbus/8041642/bug8041642.java fails

Bug : https://bugs.openjdk.java.net/browse/JDK-8079450

Webrev : http://cr.openjdk.java.net/~sgupta/8079450/webrev.00/

Thanks and Regards,
Shobhit Gupta


From alexander.kulyakhtin at oracle.com  Tue Jun  2 11:31:40 2015
From: alexander.kulyakhtin at oracle.com (Alexander Kulyakhtin)
Date: Tue, 2 Jun 2015 04:31:40 -0700 (PDT)
Subject: <Swing Dev> RFR: JDK-8076468: Add @modules to jtreg jdk_desktop
 tests to take into account the new modular architecture
Message-ID: <643a089a-bd21-4b9b-8add-ccd6674bec48@default>

Hi,

Could you, please, review the following tests-only changes to the test files from the jdk9/client repository

http://cr.openjdk.java.net/~akulyakh/8076468/webrev.02/index.html

The changes add @modules to the tests to make it possible to run the tests with jake. 

Best regards,
Alexander


From yuri.nesterenko at oracle.com  Tue Jun  2 13:29:57 2015
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Tue, 02 Jun 2015 16:29:57 +0300
Subject: <Swing Dev> RFR: JDK-8076468: Add @modules to jtreg jdk_desktop
 tests to take into account the new modular architecture
In-Reply-To: <643a089a-bd21-4b9b-8add-ccd6674bec48@default>
References: <643a089a-bd21-4b9b-8add-ccd6674bec48@default>
Message-ID: <556DAFD5.9050700@oracle.com>

Hi Alexander(s),

I have some problems not with this change but
with the routine itself.

As I understand, this change is automatically generated.
The generator script is imperfect. For instance,
it cannot catch dependencies in places like
javax/swing/RepaintManager/6608456/bug6608456.java
where tests depend on reflection to call certain internal methods.
Now, if I add the @modules line myself, manually,
it will be removed on the next run of the script.

How do you suppose to remedy that?

Same thing, sun/awt/datatransfer/DataFlavorComparatorTest.java issue.
Correct modules should be
      @modules java.datatransfer/sun.datatransfer
               java.desktop/sun.awt.datatransfer
You don't have that second line. OK, that's because jdeps
for some reason didn't catch that. Why, all programs have bugs,
and this one will be eventually fixed. But until then,
how can I fix the test? You'll break my fix again --
or every time someone should invest certain amount of manual labor.
Tonight I'm afraid that's you.

Thanks,
-yan

On 06/02/2015 02:31 PM, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review the following tests-only changes to the test files from the jdk9/client repository
>
> http://cr.openjdk.java.net/~akulyakh/8076468/webrev.02/index.html
>
> The changes add @modules to the tests to make it possible to run the tests with jake.
>
> Best regards,
> Alexander
>



From alexander.v.stepanov at oracle.com  Tue Jun  2 17:04:44 2015
From: alexander.v.stepanov at oracle.com (alexander stepanov)
Date: Tue, 02 Jun 2015 20:04:44 +0300
Subject: <Swing Dev> RFR [9] 8081313: MultipleDocumentHandling.java: tidy
	warnings
In-Reply-To: <55685481.3040702@oracle.com>
References: <55685481.3040702@oracle.com>
Message-ID: <556DE22C.7040001@oracle.com>

Sorry; was sent to wrong mailing list initially.

On 29.05.2015 14:58, alexander stepanov wrote:
> Hello,
>
> Could you please review fix
> http://cr.openjdk.java.net/~avstepan/8081313/webrev.00/
> for
> https://bugs.openjdk.java.net/browse/JDK-8081313
>
> Just a minor fix of docs; other code is not affected.
>
> Thanks,
> Alexander



From javalists at cbfiddle.com  Tue Jun  2 17:37:19 2015
From: javalists at cbfiddle.com (Alan Snyder)
Date: Tue, 2 Jun 2015 10:37:19 -0700
Subject: <Swing Dev> internal API usage: sun.awt.AppContext
In-Reply-To: <9AC86A8B-CE08-473A-8019-B8B29F7DF6CA@cbfiddle.com>
References: <9AC86A8B-CE08-473A-8019-B8B29F7DF6CA@cbfiddle.com>
Message-ID: <E3D5AC37-AF90-41D7-9705-CBE3B3CF4321@cbfiddle.com>

Is this the proper forum for asking this question? I have not seen any reply.





> On May 28, 2015, at 7:13 PM, Alan Snyder <javalists at cbfiddle.com> wrote:
> 
> I am using code ? a custom Swing look and feel ? that uses the getAppContext(), get(), put(), and remove() methods of sun.awt.AppContext to store configuration data.
> 
> Since the look and feel is registered by UIManager using the same mechanism, this seems like the right way to store configuration data for a look and feel.
> 
> I also note that AppContext advertises itself as a better solution (e.g. better than static fields) to protect applets from being disrupted by other applets, so it may have other uses.
> 
> Is there a way to duplicate this behavior using only public APIs? If not, I request that this functionality be exported in some form by JDK 9.
> 
>  Alan
> 



From philip.race at oracle.com  Tue Jun  2 19:10:38 2015
From: philip.race at oracle.com (Phil Race)
Date: Tue, 02 Jun 2015 12:10:38 -0700
Subject: <Swing Dev> <AWT Dev>  internal API usage: sun.awt.AppContext
In-Reply-To: <E3D5AC37-AF90-41D7-9705-CBE3B3CF4321@cbfiddle.com>
References: <9AC86A8B-CE08-473A-8019-B8B29F7DF6CA@cbfiddle.com>
	<E3D5AC37-AF90-41D7-9705-CBE3B3CF4321@cbfiddle.com>
Message-ID: <556DFFAE.40504@oracle.com>

Alan,

AppContext was devised to support applets running in browsers
where the JDK internal classes were shared so were in need of
a way to provide a key that was unique to each running applet.
Note that the 'advertisement' is comments on the internal source code.
Unless your L&F is installed on the JDK bootclasspath of a
the VM running applets in a browser I am not sure how this
internal class is useful to it. Otherwise storing as static variables should
work since there will be a class per classloader.
If necessary you can roll your own that just uses the ThreadGroup
as a key to get to a map .. that's what it amounts to.

-phil.

On 06/02/2015 10:37 AM, Alan Snyder wrote:
> Is this the proper forum for asking this question? I have not seen any reply.
>
>
>
>
>
>> On May 28, 2015, at 7:13 PM, Alan Snyder <javalists at cbfiddle.com> wrote:
>>
>> I am using code ? a custom Swing look and feel ? that uses the getAppContext(), get(), put(), and remove() methods of sun.awt.AppContext to store configuration data.
>>
>> Since the look and feel is registered by UIManager using the same mechanism, this seems like the right way to store configuration data for a look and feel.
>>
>> I also note that AppContext advertises itself as a better solution (e.g. better than static fields) to protect applets from being disrupted by other applets, so it may have other uses.
>>
>> Is there a way to duplicate this behavior using only public APIs? If not, I request that this functionality be exported in some form by JDK 9.
>>
>>   Alan
>>



From javalists at cbfiddle.com  Tue Jun  2 19:58:54 2015
From: javalists at cbfiddle.com (Alan Snyder)
Date: Tue, 2 Jun 2015 12:58:54 -0700
Subject: <Swing Dev> <AWT Dev>  internal API usage: sun.awt.AppContext
In-Reply-To: <556DFFAE.40504@oracle.com>
References: <9AC86A8B-CE08-473A-8019-B8B29F7DF6CA@cbfiddle.com>
	<E3D5AC37-AF90-41D7-9705-CBE3B3CF4321@cbfiddle.com>
	<556DFFAE.40504@oracle.com>
Message-ID: <D334F270-B277-4A98-9BF1-5CC4E3DFCDC3@cbfiddle.com>

Got it. Thank you.

  Alan


> On Jun 2, 2015, at 12:10 PM, Phil Race <philip.race at oracle.com> wrote:
> 
> Alan,
> 
> AppContext was devised to support applets running in browsers
> where the JDK internal classes were shared so were in need of
> a way to provide a key that was unique to each running applet.
> Note that the 'advertisement' is comments on the internal source code.
> Unless your L&F is installed on the JDK bootclasspath of a
> the VM running applets in a browser I am not sure how this
> internal class is useful to it. Otherwise storing as static variables should
> work since there will be a class per classloader.
> If necessary you can roll your own that just uses the ThreadGroup
> as a key to get to a map .. that's what it amounts to.
> 
> -phil.
> 
> On 06/02/2015 10:37 AM, Alan Snyder wrote:
>> Is this the proper forum for asking this question? I have not seen any reply.
>> 
>> 
>> 
>> 
>> 
>>> On May 28, 2015, at 7:13 PM, Alan Snyder <javalists at cbfiddle.com> wrote:
>>> 
>>> I am using code ? a custom Swing look and feel ? that uses the getAppContext(), get(), put(), and remove() methods of sun.awt.AppContext to store configuration data.
>>> 
>>> Since the look and feel is registered by UIManager using the same mechanism, this seems like the right way to store configuration data for a look and feel.
>>> 
>>> I also note that AppContext advertises itself as a better solution (e.g. better than static fields) to protect applets from being disrupted by other applets, so it may have other uses.
>>> 
>>> Is there a way to duplicate this behavior using only public APIs? If not, I request that this functionality be exported in some form by JDK 9.
>>> 
>>>  Alan
>>> 
> 



From shobhit.s.gupta at oracle.com  Wed Jun  3 04:52:09 2015
From: shobhit.s.gupta at oracle.com (shobhit gupta)
Date: Wed, 03 Jun 2015 10:22:09 +0530
Subject: <Swing Dev> [9-dev] Review request for bug 8079253 : [TESTBUG] Test
 javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails
Message-ID: <556E87F9.1040007@oracle.com>

Hi,

Please review a fix for the issue:

8079253 : [TESTBUG] Test 
javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

Bug : https://bugs.openjdk.java.net/browse/JDK-8079253

Webrev : http://cr.openjdk.java.net/~sgupta/8079253/webrev.00/

Thanks and Regards,
Shobhit Gupta




From alexander.v.stepanov at oracle.com  Wed Jun  3 11:29:51 2015
From: alexander.v.stepanov at oracle.com (alexander stepanov)
Date: Wed, 03 Jun 2015 14:29:51 +0300
Subject: <Swing Dev>  RFR 8077036: swing docs: fix some tidy warnings
Message-ID: <556EE52F.7050208@oracle.com>

Hello,

Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8077036/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8077036

Just some minor docs cleanup; no other code affected.

Thanks,
Alexander


From alexandr.scherbatiy at oracle.com  Wed Jun  3 12:04:32 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 03 Jun 2015 15:04:32 +0300
Subject: <Swing Dev> RFR [9] 8081313: MultipleDocumentHandling.java:
 tidy warnings
In-Reply-To: <55685481.3040702@oracle.com>
References: <55685481.3040702@oracle.com>
Message-ID: <556EED50.8040102@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 5/29/2015 2:58 PM, alexander stepanov wrote:
> Hello,
>
> Could you please review fix
> http://cr.openjdk.java.net/~avstepan/8081313/webrev.00/
> for
> https://bugs.openjdk.java.net/browse/JDK-8081313
>
> Just a minor fix of docs; other code is not affected.
>
> Thanks,
> Alexander



From alexandr.scherbatiy at oracle.com  Wed Jun  3 12:06:11 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 03 Jun 2015 15:06:11 +0300
Subject: <Swing Dev> [9-dev] Review request for bug 8079450 : [TESTBUG]
 javax/swing/plaf/nimbus/8041642/bug8041642.java fails
In-Reply-To: <556D3B78.7040102@oracle.com>
References: <556D3B78.7040102@oracle.com>
Message-ID: <556EEDB3.9030106@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/2/2015 8:13 AM, shobhit gupta wrote:
> Hi,
>
> Please review a fix for the issue:
>
> 8079450 : [TESTBUG] javax/swing/plaf/nimbus/8041642/bug8041642.java fails
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8079450
>
> Webrev : http://cr.openjdk.java.net/~sgupta/8079450/webrev.00/
>
> Thanks and Regards,
> Shobhit Gupta



From alexandr.scherbatiy at oracle.com  Wed Jun  3 12:13:01 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 03 Jun 2015 15:13:01 +0300
Subject: <Swing Dev> [9-dev] Review request for bug 8079253 : [TESTBUG]
 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails
In-Reply-To: <556E87F9.1040007@oracle.com>
References: <556E87F9.1040007@oracle.com>
Message-ID: <556EEF4D.1000304@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/3/2015 7:52 AM, shobhit gupta wrote:
> Hi,
>
> Please review a fix for the issue:
>
> 8079253 : [TESTBUG] Test 
> javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8079253
>
> Webrev : http://cr.openjdk.java.net/~sgupta/8079253/webrev.00/
>
> Thanks and Regards,
> Shobhit Gupta
>
>



From alexandr.scherbatiy at oracle.com  Wed Jun  3 12:16:41 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 03 Jun 2015 15:16:41 +0300
Subject: <Swing Dev> RFR 8077036: swing docs: fix some tidy warnings
In-Reply-To: <556EE52F.7050208@oracle.com>
References: <556EE52F.7050208@oracle.com>
Message-ID: <556EF029.40109@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/3/2015 2:29 PM, alexander stepanov wrote:
> Hello,
>
> Could you please review the following fix
> http://cr.openjdk.java.net/~avstepan/8077036/webrev.00/
> for
> https://bugs.openjdk.java.net/browse/JDK-8077036
>
> Just some minor docs cleanup; no other code affected.
>
> Thanks,
> Alexander



From alexander.v.stepanov at oracle.com  Wed Jun  3 12:35:33 2015
From: alexander.v.stepanov at oracle.com (alexander stepanov)
Date: Wed, 03 Jun 2015 15:35:33 +0300
Subject: <Swing Dev> RFR [9] 8081313: MultipleDocumentHandling.java:
 tidy warnings
In-Reply-To: <556EED50.8040102@oracle.com>
References: <55685481.3040702@oracle.com> <556EED50.8040102@oracle.com>
Message-ID: <556EF495.3060008@oracle.com>

Thanks!

On 03.06.2015 15:04, Alexander Scherbatiy wrote:
>
>   The fix looks good to me.
>
>   Thanks,
>   Alexandr.
>
> On 5/29/2015 2:58 PM, alexander stepanov wrote:
>> Hello,
>>
>> Could you please review fix
>> http://cr.openjdk.java.net/~avstepan/8081313/webrev.00/
>> for
>> https://bugs.openjdk.java.net/browse/JDK-8081313
>>
>> Just a minor fix of docs; other code is not affected.
>>
>> Thanks,
>> Alexander
>



From alexander.v.stepanov at oracle.com  Wed Jun  3 12:35:47 2015
From: alexander.v.stepanov at oracle.com (alexander stepanov)
Date: Wed, 03 Jun 2015 15:35:47 +0300
Subject: <Swing Dev> RFR 8077036: swing docs: fix some tidy warnings
In-Reply-To: <556EF029.40109@oracle.com>
References: <556EE52F.7050208@oracle.com> <556EF029.40109@oracle.com>
Message-ID: <556EF4A3.6020706@oracle.com>

Thanks!

On 03.06.2015 15:16, Alexander Scherbatiy wrote:
>
>   The fix looks good to me.
>
>   Thanks,
>   Alexandr.
>
> On 6/3/2015 2:29 PM, alexander stepanov wrote:
>> Hello,
>>
>> Could you please review the following fix
>> http://cr.openjdk.java.net/~avstepan/8077036/webrev.00/
>> for
>> https://bugs.openjdk.java.net/browse/JDK-8077036
>>
>> Just some minor docs cleanup; no other code affected.
>>
>> Thanks,
>> Alexander
>



From Sergey.Bylokhov at oracle.com  Wed Jun  3 15:20:09 2015
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 03 Jun 2015 18:20:09 +0300
Subject: <Swing Dev> [9-dev] Review request for bug 8079253 : [TESTBUG]
 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails
In-Reply-To: <556E87F9.1040007@oracle.com>
References: <556E87F9.1040007@oracle.com>
Message-ID: <556F1B29.1000008@oracle.com>

Hi,
Why do you think this issue is a test bug?

On 03.06.15 7:52, shobhit gupta wrote:
> Hi,
>
> Please review a fix for the issue:
>
> 8079253 : [TESTBUG] Test 
> javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8079253
>
> Webrev : http://cr.openjdk.java.net/~sgupta/8079253/webrev.00/
>
> Thanks and Regards,
> Shobhit Gupta
>
>


-- 
Best regards, Sergey.



From pooja.chopra at oracle.com  Mon Jun  8 09:57:30 2015
From: pooja.chopra at oracle.com (pooja chopra)
Date: Mon, 08 Jun 2015 15:27:30 +0530
Subject: <Swing Dev> < Swing Dev> [9] Review Request: JDK-8081764 [TEST_BUG]
 Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris
 Sparcv9 and Linux but passes on MacOSX
Message-ID: <5575670A.6060802@oracle.com>

Hello,

Please review a fix for issue :-
8081764  [TEST_BUG] Test 
javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris 
Sparcv9 and Linux but passes on MacOSX
Test bug fix.
https://bugs.openjdk.java.net/browse/JDK-8081764
The webrev is :  http://cr.openjdk.java.net/~pchopra/8081764

Regards,
Pooja



From pooja.chopra at oracle.com  Mon Jun  8 09:59:42 2015
From: pooja.chopra at oracle.com (pooja chopra)
Date: Mon, 08 Jun 2015 15:29:42 +0530
Subject: <Swing Dev> < Swing Dev> [9] Review Request: JDK-8081764
 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on
 Solaris Sparcv9 and Linux but passes on MacOSX
In-Reply-To: <5575670A.6060802@oracle.com>
References: <5575670A.6060802@oracle.com>
Message-ID: <5575678E.2080803@oracle.com>

Hi All,
Correcting the webrev link below . Please review below fix .
Regards,
Pooja
On 6/8/2015 3:27 PM, pooja chopra wrote:
> Hello,
>
> Please review a fix for issue :-
> 8081764  [TEST_BUG] Test 
> javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris 
> Sparcv9 and Linux but passes on MacOSX
> Test bug fix.
> https://bugs.openjdk.java.net/browse/JDK-8081764
> The webrev is : http://cr.openjdk.java.net/~pchopra/8081764/webrev.00
>
> Regards,
> Pooja
>



From semyon.sadetsky at oracle.com  Mon Jun  8 13:33:08 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Mon, 08 Jun 2015 16:33:08 +0300
Subject: <Swing Dev> [9] Review Request for 8078269: JTabbedPane UI
 Property TabbedPane.tabAreaBackground no longer works
In-Reply-To: <5555E22E.6090803@oracle.com>
References: <5554AD43.6010702@oracle.com>
	<5554B3A4.70200@oracle.com>	<5554B8A0.2090900@oracle.com>
	<5555D34A.1070704@oracle.com> <5555E22E.6090803@oracle.com>
Message-ID: <55759994.4080404@oracle.com>

Hi Sergey,

as agreed I've added UIResource check: 
http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/

--Semyon


On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
>
> On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
>> On 14.05.15 18:00, Semyon Sadetsky wrote:
>>> Sergey,
>>>
>>> Why the component background priority looks reasonable for you?
>> Because otherwise there is no way to change the color of one 
>> particular component.
>>> A component has only one background color which is set by L&F to the 
>>> default value. But it is not enough for the tabbed pane component 
>>> which has more then one background surfaces and L&F can define more 
>>> background colors to paint tabbed pane more precisely. In this case 
>>> the common component background should have second priority.
>> What is the difference between "TabbedPane.background" and 
>> "TabbedPane.tabAreaBackground" in the metal l&f? 
> "TabbedPane.background" is the default background.
>
>>>
>>> --Semyon
>>>
>>> On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
>>>> Hi, Semyon.
>>>> Usage of background(if it was set) instead of property looks 
>>>> reasonable. Please clarify who sets default color of component 
>>>> explicitly to the value other than from UI property?
>>>>
>>>> On 14.05.15 17:12, Semyon Sadetsky wrote:
>>>>> Hello,
>>>>>
>>>>> Please review fix for JDK9:
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>>>>
>>>>> This is regression of the 8007563 which was incorrect fix of the 
>>>>> 4690946 regression.
>>>>> Actually the 4690946 was a test bug because tab area's background 
>>>>> can be controlled separately using "TabbedPane.tabAreaBackground" 
>>>>> property.
>>>>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. Test of 
>>>>> the 4690946 is fixed to take this into account.
>>>>>
>>>>> Also inappropriate design chosen for the 8007563 reg test code 
>>>>> affected test results stability. It also has been fixed.
>>>>>
>>>>> --Semyon
>>>>
>>>>
>>>
>>
>>
>> -- 
>> Best regards, Sergey.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150608/33624eca/attachment.html>

From Sergey.Bylokhov at oracle.com  Mon Jun  8 17:29:25 2015
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 08 Jun 2015 20:29:25 +0300
Subject: <Swing Dev> [9] Review Request for 8078269: JTabbedPane UI
 Property TabbedPane.tabAreaBackground no longer works
In-Reply-To: <55759994.4080404@oracle.com>
References: <5554AD43.6010702@oracle.com>
	<5554B3A4.70200@oracle.com>	<5554B8A0.2090900@oracle.com>
	<5555D34A.1070704@oracle.com> <5555E22E.6090803@oracle.com>
	<55759994.4080404@oracle.com>
Message-ID: <5575D0F5.4070109@oracle.com>

On 08.06.15 16:33, Semyon Sadetsky wrote:
> Hi Sergey,
>
> as agreed I've added UIResource check: 
> http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
Note that null value is not a UIResource, but tabAreaBackground should 
be used in this case.
>
> --Semyon
>
>
> On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
>>
>> On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
>>> On 14.05.15 18:00, Semyon Sadetsky wrote:
>>>> Sergey,
>>>>
>>>> Why the component background priority looks reasonable for you?
>>> Because otherwise there is no way to change the color of one 
>>> particular component.
>>>> A component has only one background color which is set by L&F to 
>>>> the default value. But it is not enough for the tabbed pane 
>>>> component which has more then one background surfaces and L&F can 
>>>> define more background colors to paint tabbed pane more precisely. 
>>>> In this case the common component background should have second 
>>>> priority.
>>> What is the difference between "TabbedPane.background" and 
>>> "TabbedPane.tabAreaBackground" in the metal l&f? 
>> "TabbedPane.background" is the default background.
>>
>>>>
>>>> --Semyon
>>>>
>>>> On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
>>>>> Hi, Semyon.
>>>>> Usage of background(if it was set) instead of property looks 
>>>>> reasonable. Please clarify who sets default color of component 
>>>>> explicitly to the value other than from UI property?
>>>>>
>>>>> On 14.05.15 17:12, Semyon Sadetsky wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review fix for JDK9:
>>>>>>
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>>>>>
>>>>>> This is regression of the 8007563 which was incorrect fix of the 
>>>>>> 4690946 regression.
>>>>>> Actually the 4690946 was a test bug because tab area's background 
>>>>>> can be controlled separately using "TabbedPane.tabAreaBackground" 
>>>>>> property.
>>>>>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. Test 
>>>>>> of the 4690946 is fixed to take this into account.
>>>>>>
>>>>>> Also inappropriate design chosen for the 8007563 reg test code 
>>>>>> affected test results stability. It also has been fixed.
>>>>>>
>>>>>> --Semyon
>>>>>
>>>>>
>>>>
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150608/a8f58542/attachment.html>

From Sergey.Bylokhov at oracle.com  Mon Jun  8 17:33:28 2015
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 08 Jun 2015 20:33:28 +0300
Subject: <Swing Dev> [9] Review Request for 8078269: JTabbedPane UI
 Property TabbedPane.tabAreaBackground no longer works
In-Reply-To: <5575D0F5.4070109@oracle.com>
References: <5554AD43.6010702@oracle.com>
	<5554B3A4.70200@oracle.com>	<5554B8A0.2090900@oracle.com>
	<5555D34A.1070704@oracle.com> <5555E22E.6090803@oracle.com>
	<55759994.4080404@oracle.com> <5575D0F5.4070109@oracle.com>
Message-ID: <5575D1E8.2070107@oracle.com>

On 08.06.15 20:29, Sergey Bylokhov wrote:
> On 08.06.15 16:33, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> as agreed I've added UIResource check: 
>> http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
> Note that null value is not a UIResource, but tabAreaBackground should 
> be used in this case.
Or it should not? Will our components survive null background color? I 
guess we should check how UIResource usually check a null value.
>>
>> --Semyon
>>
>>
>> On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
>>>
>>> On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
>>>> On 14.05.15 18:00, Semyon Sadetsky wrote:
>>>>> Sergey,
>>>>>
>>>>> Why the component background priority looks reasonable for you?
>>>> Because otherwise there is no way to change the color of one 
>>>> particular component.
>>>>> A component has only one background color which is set by L&F to 
>>>>> the default value. But it is not enough for the tabbed pane 
>>>>> component which has more then one background surfaces and L&F can 
>>>>> define more background colors to paint tabbed pane more precisely. 
>>>>> In this case the common component background should have second 
>>>>> priority.
>>>> What is the difference between "TabbedPane.background" and 
>>>> "TabbedPane.tabAreaBackground" in the metal l&f? 
>>> "TabbedPane.background" is the default background.
>>>
>>>>>
>>>>> --Semyon
>>>>>
>>>>> On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
>>>>>> Hi, Semyon.
>>>>>> Usage of background(if it was set) instead of property looks 
>>>>>> reasonable. Please clarify who sets default color of component 
>>>>>> explicitly to the value other than from UI property?
>>>>>>
>>>>>> On 14.05.15 17:12, Semyon Sadetsky wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Please review fix for JDK9:
>>>>>>>
>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>>>>>>
>>>>>>> This is regression of the 8007563 which was incorrect fix of the 
>>>>>>> 4690946 regression.
>>>>>>> Actually the 4690946 was a test bug because tab area's 
>>>>>>> background can be controlled separately using 
>>>>>>> "TabbedPane.tabAreaBackground" property.
>>>>>>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. Test 
>>>>>>> of the 4690946 is fixed to take this into account.
>>>>>>>
>>>>>>> Also inappropriate design chosen for the 8007563 reg test code 
>>>>>>> affected test results stability. It also has been fixed.
>>>>>>>
>>>>>>> --Semyon
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> -- 
>>>> Best regards, Sergey.
>>>
>>
>
>
> -- 
> Best regards, Sergey.


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150608/e61034b0/attachment.html>

From semyon.sadetsky at oracle.com  Tue Jun  9 06:41:27 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Tue, 09 Jun 2015 09:41:27 +0300
Subject: <Swing Dev> [9] Review Request for 8078269: JTabbedPane UI
 Property TabbedPane.tabAreaBackground no longer works
In-Reply-To: <5575D1E8.2070107@oracle.com>
References: <5554AD43.6010702@oracle.com>
	<5554B3A4.70200@oracle.com>	<5554B8A0.2090900@oracle.com>
	<5555D34A.1070704@oracle.com> <5555E22E.6090803@oracle.com>
	<55759994.4080404@oracle.com> <5575D0F5.4070109@oracle.com>
	<5575D1E8.2070107@oracle.com>
Message-ID: <55768A97.8000904@oracle.com>


On 6/8/2015 8:33 PM, Sergey Bylokhov wrote:
> On 08.06.15 20:29, Sergey Bylokhov wrote:
>> On 08.06.15 16:33, Semyon Sadetsky wrote:
>>> Hi Sergey,
>>>
>>> as agreed I've added UIResource check: 
>>> http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
>> Note that null value is not a UIResource, but tabAreaBackground 
>> should be used in this case.
> Or it should not? Will our components survive null background color? I 
> guess we should check how UIResource usually check a null value.
Not 100% sure that component background is allowed to be null, but if it 
is then it was set by user and we should use user's preference as we 
discuses offline.

--Semyon

>>>
>>> --Semyon
>>>
>>>
>>> On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
>>>>
>>>> On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
>>>>> On 14.05.15 18:00, Semyon Sadetsky wrote:
>>>>>> Sergey,
>>>>>>
>>>>>> Why the component background priority looks reasonable for you?
>>>>> Because otherwise there is no way to change the color of one 
>>>>> particular component.
>>>>>> A component has only one background color which is set by L&F to 
>>>>>> the default value. But it is not enough for the tabbed pane 
>>>>>> component which has more then one background surfaces and L&F can 
>>>>>> define more background colors to paint tabbed pane more 
>>>>>> precisely. In this case the common component background should 
>>>>>> have second priority.
>>>>> What is the difference between "TabbedPane.background" and 
>>>>> "TabbedPane.tabAreaBackground" in the metal l&f? 
>>>> "TabbedPane.background" is the default background.
>>>>
>>>>>>
>>>>>> --Semyon
>>>>>>
>>>>>> On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
>>>>>>> Hi, Semyon.
>>>>>>> Usage of background(if it was set) instead of property looks 
>>>>>>> reasonable. Please clarify who sets default color of component 
>>>>>>> explicitly to the value other than from UI property?
>>>>>>>
>>>>>>> On 14.05.15 17:12, Semyon Sadetsky wrote:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> Please review fix for JDK9:
>>>>>>>>
>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>>>>>>>
>>>>>>>> This is regression of the 8007563 which was incorrect fix of 
>>>>>>>> the 4690946 regression.
>>>>>>>> Actually the 4690946 was a test bug because tab area's 
>>>>>>>> background can be controlled separately using 
>>>>>>>> "TabbedPane.tabAreaBackground" property.
>>>>>>>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. Test 
>>>>>>>> of the 4690946 is fixed to take this into account.
>>>>>>>>
>>>>>>>> Also inappropriate design chosen for the 8007563 reg test code 
>>>>>>>> affected test results stability. It also has been fixed.
>>>>>>>>
>>>>>>>> --Semyon
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> -- 
>>>>> Best regards, Sergey.
>>>>
>>>
>>
>>
>> -- 
>> Best regards, Sergey.
>
>
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150609/cb2dfdea/attachment.html>

From andrew.brygin at oracle.com  Tue Jun  9 07:45:22 2015
From: andrew.brygin at oracle.com (Andrew Brygin)
Date: Tue, 09 Jun 2015 10:45:22 +0300
Subject: <Swing Dev> < Swing Dev> [9] Review Request: JDK-8081764
 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on
 Solaris Sparcv9 and Linux but passes on MacOSX
In-Reply-To: <5575678E.2080803@oracle.com>
References: <5575670A.6060802@oracle.com> <5575678E.2080803@oracle.com>
Message-ID: <55769992.6090505@oracle.com>

Hello Pooja,

  In general I tend to agree with idea to limit the scope of the test by 
macosx only.

  However, could you please clarify following questions:
a) the test failure on linux/solaris: doesn't it indicate a similar 
problem with gtk laf, does it?
b) what is purpose of the explicit LaF setup (lines 68 - 69)?

Thanks,
Andrew

On 6/8/2015 12:59 PM, pooja chopra wrote:
> Hi All,
> Correcting the webrev link below . Please review below fix .
> Regards,
> Pooja
> On 6/8/2015 3:27 PM, pooja chopra wrote:
>> Hello,
>>
>> Please review a fix for issue :-
>> 8081764  [TEST_BUG] Test 
>> javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris 
>> Sparcv9 and Linux but passes on MacOSX
>> Test bug fix.
>> https://bugs.openjdk.java.net/browse/JDK-8081764
>> The webrev is : http://cr.openjdk.java.net/~pchopra/8081764/webrev.00
>>
>> Regards,
>> Pooja
>>
>



From Sergey.Bylokhov at oracle.com  Tue Jun  9 14:44:10 2015
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 09 Jun 2015 17:44:10 +0300
Subject: <Swing Dev> [9] Review Request for 8078269: JTabbedPane UI
 Property TabbedPane.tabAreaBackground no longer works
In-Reply-To: <55768A97.8000904@oracle.com>
References: <5554AD43.6010702@oracle.com>
	<5554B3A4.70200@oracle.com>	<5554B8A0.2090900@oracle.com>
	<5555D34A.1070704@oracle.com> <5555E22E.6090803@oracle.com>
	<55759994.4080404@oracle.com> <5575D0F5.4070109@oracle.com>
	<5575D1E8.2070107@oracle.com> <55768A97.8000904@oracle.com>
Message-ID: <5576FBBA.7050708@oracle.com>

On 09.06.15 9:41, Semyon Sadetsky wrote:
>
> On 6/8/2015 8:33 PM, Sergey Bylokhov wrote:
>> On 08.06.15 20:29, Sergey Bylokhov wrote:
>>> On 08.06.15 16:33, Semyon Sadetsky wrote:
>>>> Hi Sergey,
>>>>
>>>> as agreed I've added UIResource check: 
>>>> http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
>>> Note that null value is not a UIResource, but tabAreaBackground 
>>> should be used in this case.
>> Or it should not? Will our components survive null background color? 
>> I guess we should check how UIResource usually check a null value.
> Not 100% sure that component background is allowed to be null, but if 
> it is then it was set by user and we should use user's preference as 
> we discuses offline.
ok. looks fine.
>
> --Semyon
>
>>>>
>>>> --Semyon
>>>>
>>>>
>>>> On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
>>>>>
>>>>> On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
>>>>>> On 14.05.15 18:00, Semyon Sadetsky wrote:
>>>>>>> Sergey,
>>>>>>>
>>>>>>> Why the component background priority looks reasonable for you?
>>>>>> Because otherwise there is no way to change the color of one 
>>>>>> particular component.
>>>>>>> A component has only one background color which is set by L&F to 
>>>>>>> the default value. But it is not enough for the tabbed pane 
>>>>>>> component which has more then one background surfaces and L&F 
>>>>>>> can define more background colors to paint tabbed pane more 
>>>>>>> precisely. In this case the common component background should 
>>>>>>> have second priority.
>>>>>> What is the difference between "TabbedPane.background" and 
>>>>>> "TabbedPane.tabAreaBackground" in the metal l&f? 
>>>>> "TabbedPane.background" is the default background.
>>>>>
>>>>>>>
>>>>>>> --Semyon
>>>>>>>
>>>>>>> On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
>>>>>>>> Hi, Semyon.
>>>>>>>> Usage of background(if it was set) instead of property looks 
>>>>>>>> reasonable. Please clarify who sets default color of component 
>>>>>>>> explicitly to the value other than from UI property?
>>>>>>>>
>>>>>>>> On 14.05.15 17:12, Semyon Sadetsky wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review fix for JDK9:
>>>>>>>>>
>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>>>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>>>>>>>>
>>>>>>>>> This is regression of the 8007563 which was incorrect fix of 
>>>>>>>>> the 4690946 regression.
>>>>>>>>> Actually the 4690946 was a test bug because tab area's 
>>>>>>>>> background can be controlled separately using 
>>>>>>>>> "TabbedPane.tabAreaBackground" property.
>>>>>>>>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. 
>>>>>>>>> Test of the 4690946 is fixed to take this into account.
>>>>>>>>>
>>>>>>>>> Also inappropriate design chosen for the 8007563 reg test code 
>>>>>>>>> affected test results stability. It also has been fixed.
>>>>>>>>>
>>>>>>>>> --Semyon
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> -- 
>>>>>> Best regards, Sergey.
>>>>>
>>>>
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>>
>> -- 
>> Best regards, Sergey.
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150609/169191e0/attachment.html>

From alexandr.scherbatiy at oracle.com  Tue Jun  9 15:07:17 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Tue, 09 Jun 2015 18:07:17 +0300
Subject: <Swing Dev> [9] Review Request for 8078269: JTabbedPane UI
 Property TabbedPane.tabAreaBackground no longer works
In-Reply-To: <5576FBBA.7050708@oracle.com>
References: <5554AD43.6010702@oracle.com>
	<5554B3A4.70200@oracle.com>	<5554B8A0.2090900@oracle.com>
	<5555D34A.1070704@oracle.com> <5555E22E.6090803@oracle.com>
	<55759994.4080404@oracle.com> <5575D0F5.4070109@oracle.com>
	<5575D1E8.2070107@oracle.com> <55768A97.8000904@oracle.com>
	<5576FBBA.7050708@oracle.com>
Message-ID: <55770125.4020702@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/9/2015 5:44 PM, Sergey Bylokhov wrote:
> On 09.06.15 9:41, Semyon Sadetsky wrote:
>>
>> On 6/8/2015 8:33 PM, Sergey Bylokhov wrote:
>>> On 08.06.15 20:29, Sergey Bylokhov wrote:
>>>> On 08.06.15 16:33, Semyon Sadetsky wrote:
>>>>> Hi Sergey,
>>>>>
>>>>> as agreed I've added UIResource check: 
>>>>> http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
>>>> Note that null value is not a UIResource, but tabAreaBackground 
>>>> should be used in this case.
>>> Or it should not? Will our components survive null background color? 
>>> I guess we should check how UIResource usually check a null value.
>> Not 100% sure that component background is allowed to be null, but if 
>> it is then it was set by user and we should use user's preference as 
>> we discuses offline.
> ok. looks fine.
>>
>> --Semyon
>>
>>>>>
>>>>> --Semyon
>>>>>
>>>>>
>>>>> On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
>>>>>>
>>>>>> On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
>>>>>>> On 14.05.15 18:00, Semyon Sadetsky wrote:
>>>>>>>> Sergey,
>>>>>>>>
>>>>>>>> Why the component background priority looks reasonable for you?
>>>>>>> Because otherwise there is no way to change the color of one 
>>>>>>> particular component.
>>>>>>>> A component has only one background color which is set by L&F 
>>>>>>>> to the default value. But it is not enough for the tabbed pane 
>>>>>>>> component which has more then one background surfaces and L&F 
>>>>>>>> can define more background colors to paint tabbed pane more 
>>>>>>>> precisely. In this case the common component background should 
>>>>>>>> have second priority.
>>>>>>> What is the difference between "TabbedPane.background" and 
>>>>>>> "TabbedPane.tabAreaBackground" in the metal l&f? 
>>>>>> "TabbedPane.background" is the default background.
>>>>>>
>>>>>>>>
>>>>>>>> --Semyon
>>>>>>>>
>>>>>>>> On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
>>>>>>>>> Hi, Semyon.
>>>>>>>>> Usage of background(if it was set) instead of property looks 
>>>>>>>>> reasonable. Please clarify who sets default color of component 
>>>>>>>>> explicitly to the value other than from UI property?
>>>>>>>>>
>>>>>>>>> On 14.05.15 17:12, Semyon Sadetsky wrote:
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> Please review fix for JDK9:
>>>>>>>>>>
>>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>>>>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>>>>>>>>>
>>>>>>>>>> This is regression of the 8007563 which was incorrect fix of 
>>>>>>>>>> the 4690946 regression.
>>>>>>>>>> Actually the 4690946 was a test bug because tab area's 
>>>>>>>>>> background can be controlled separately using 
>>>>>>>>>> "TabbedPane.tabAreaBackground" property.
>>>>>>>>>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. 
>>>>>>>>>> Test of the 4690946 is fixed to take this into account.
>>>>>>>>>>
>>>>>>>>>> Also inappropriate design chosen for the 8007563 reg test 
>>>>>>>>>> code affected test results stability. It also has been fixed.
>>>>>>>>>>
>>>>>>>>>> --Semyon
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> -- 
>>>>>>> Best regards, Sergey.
>>>>>>
>>>>>
>>>>
>>>>
>>>> -- 
>>>> Best regards, Sergey.
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>
>
> -- 
> Best regards, Sergey.



From pooja.chopra at oracle.com  Thu Jun 11 08:53:00 2015
From: pooja.chopra at oracle.com (pooja chopra)
Date: Thu, 11 Jun 2015 14:23:00 +0530
Subject: <Swing Dev> < Swing Dev> [9] Review Request: JDK-8081764
 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on
 Solaris Sparcv9 and Linux but passes on MacOSX
In-Reply-To: <55769992.6090505@oracle.com>
References: <5575670A.6060802@oracle.com> <5575678E.2080803@oracle.com>
	<55769992.6090505@oracle.com>
Message-ID: <55794C6C.2030807@oracle.com>

Hi Andrew ,
The test  passes with GTKLookAndFeel on Solaris but with out 
GTKLookAndFeel test fails with same error as mentioned in the bug . I 
had explicitly set the look and feel as system look and feel as test was 
to be run for Mac only and this test was placed in plaf/aqua and it is 
comparing screenshots so I thought in other look and feel there can be a 
possibility  that this matching fails. Please let me know if some 
changes are required .
Regards,
Pooja
On 6/9/2015 1:15 PM, Andrew Brygin wrote:
> Hello Pooja,
>
>  In general I tend to agree with idea to limit the scope of the test 
> by macosx only.
>
>  However, could you please clarify following questions:
> a) the test failure on linux/solaris: doesn't it indicate a similar 
> problem with gtk laf, does it?
> b) what is purpose of the explicit LaF setup (lines 68 - 69)?
>
> Thanks,
> Andrew
>
> On 6/8/2015 12:59 PM, pooja chopra wrote:
>> Hi All,
>> Correcting the webrev link below . Please review below fix .
>> Regards,
>> Pooja
>> On 6/8/2015 3:27 PM, pooja chopra wrote:
>>> Hello,
>>>
>>> Please review a fix for issue :-
>>> 8081764  [TEST_BUG] Test 
>>> javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris 
>>> Sparcv9 and Linux but passes on MacOSX
>>> Test bug fix.
>>> https://bugs.openjdk.java.net/browse/JDK-8081764
>>> The webrev is : http://cr.openjdk.java.net/~pchopra/8081764/webrev.00
>>>
>>> Regards,
>>> Pooja
>>>
>>
>



From javalists at cbfiddle.com  Thu Jun 11 15:09:40 2015
From: javalists at cbfiddle.com (Alan Snyder)
Date: Thu, 11 Jun 2015 08:09:40 -0700
Subject: <Swing Dev> OS X screen menu bar support in JDK 9
Message-ID: <076559B8-2818-49D8-86CE-ED58CE720B4F@cbfiddle.com>

I am wondering whether the hiding of JDK internal classes in JDK 9 might prevent a third party look and feel from using the screen menu bar. The reason is that the screen menu bar support is tightly bound to classes in the Aqua look and feel, specifically AquaMenuBarUI and AquaMenuItemUI, which will no longer be accessible.

Is there a solution that I am not aware of?

  Alan



From alexey.ivanov at oracle.com  Mon Jun 15 13:32:32 2015
From: alexey.ivanov at oracle.com (Alexey Ivanov)
Date: Mon, 15 Jun 2015 16:32:32 +0300
Subject: <Swing Dev> [9] Review request for 8087110: [TESTBUG] Test
 javax/swing/JFileChooser/8002077/bug8002077.java fails
Message-ID: <557ED3F0.1030507@oracle.com>

Hello Swing team,

Could you please review the fix:
     JBS: https://bugs.openjdk.java.net/browse/JDK-8087110
     webrev: http://cr.openjdk.java.net/~aivanov/8087110/jdk9/webrev.00/

Description:
This test fails because Save button in JFileChooser has no mnemonic 
after the fix for JDK-8080628.
So the test javax/swing/JFileChooser/8002077/bug8002077.java has become 
redundant and I'm removing it.

Thanks,
Alexey


From alexandr.scherbatiy at oracle.com  Tue Jun 16 16:01:47 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Tue, 16 Jun 2015 19:01:47 +0300
Subject: <Swing Dev> [9] Review request for 8087110: [TESTBUG] Test
 javax/swing/JFileChooser/8002077/bug8002077.java fails
In-Reply-To: <557ED3F0.1030507@oracle.com>
References: <557ED3F0.1030507@oracle.com>
Message-ID: <5580486B.1040609@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/15/2015 4:32 PM, Alexey Ivanov wrote:
> Hello Swing team,
>
> Could you please review the fix:
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8087110
>     webrev: http://cr.openjdk.java.net/~aivanov/8087110/jdk9/webrev.00/
>
> Description:
> This test fails because Save button in JFileChooser has no mnemonic 
> after the fix for JDK-8080628.
> So the test javax/swing/JFileChooser/8002077/bug8002077.java has 
> become redundant and I'm removing it.
>
> Thanks,
> Alexey



From semyon.sadetsky at oracle.com  Tue Jun 16 17:27:27 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Tue, 16 Jun 2015 20:27:27 +0300
Subject: <Swing Dev> [9] Review Request for 8098835: [PIT] Endless loop in
 JEditorPane
Message-ID: <55805C7F.7040602@oracle.com>

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8098835
webrev: http://cr.openjdk.java.net/~ssadetsky/8098835/webrev.00/

It is regression of https://bugs.openjdk.java.net/browse/JDK-6866751.
Some important palaces in the BasicTextUI where width should be 
increased on the caret width have been missed.

--Semyon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150616/0bec2f38/attachment.html>

From Sergey.Bylokhov at oracle.com  Tue Jun 16 18:42:47 2015
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 16 Jun 2015 21:42:47 +0300
Subject: <Swing Dev> [9] Review request for 8087110: [TESTBUG] Test
 javax/swing/JFileChooser/8002077/bug8002077.java fails
In-Reply-To: <5580486B.1040609@oracle.com>
References: <557ED3F0.1030507@oracle.com> <5580486B.1040609@oracle.com>
Message-ID: <55806E27.7080308@oracle.com>

Probably we can check that mnemonic does not work, and after that check 
that the enter actually works? I recall that mnemonic was removed 
because enter is a default key anyway?

On 16.06.15 19:01, Alexander Scherbatiy wrote:
>
>   The fix looks good to me.
>
>   Thanks,
>   Alexandr.
>
> On 6/15/2015 4:32 PM, Alexey Ivanov wrote:
>> Hello Swing team,
>>
>> Could you please review the fix:
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8087110
>>     webrev: http://cr.openjdk.java.net/~aivanov/8087110/jdk9/webrev.00/
>>
>> Description:
>> This test fails because Save button in JFileChooser has no mnemonic 
>> after the fix for JDK-8080628.
>> So the test javax/swing/JFileChooser/8002077/bug8002077.java has 
>> become redundant and I'm removing it.
>>
>> Thanks,
>> Alexey
>


-- 
Best regards, Sergey.



From alexandr.scherbatiy at oracle.com  Wed Jun 17 12:21:47 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 17 Jun 2015 15:21:47 +0300
Subject: <Swing Dev> [9] Review Request for 8098835: [PIT] Endless loop
 in JEditorPane
In-Reply-To: <55805C7F.7040602@oracle.com>
References: <55805C7F.7040602@oracle.com>
Message-ID: <5581665B.5010903@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/16/2015 8:27 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8098835
> webrev: http://cr.openjdk.java.net/~ssadetsky/8098835/webrev.00/
>
> It is regression of https://bugs.openjdk.java.net/browse/JDK-6866751.
> Some important palaces in the BasicTextUI where width should be 
> increased on the caret width have been missed.
>
> --Semyon
>



From alexander.kulyakhtin at oracle.com  Mon Jun 22 15:44:18 2015
From: alexander.kulyakhtin at oracle.com (Alexander Kulyakhtin)
Date: Mon, 22 Jun 2015 08:44:18 -0700 (PDT)
Subject: <Swing Dev> RFR: JDK-8076468 Add @modules to tests in jdk_desktop
	test group
Message-ID: <65abc491-66be-450e-b519-63e2bcbd258b@default>

Hi,

Could you, please, review the test-only changes for the JDK-8076468

CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/

@modules keywords have been added to the jtreg tests so that the tests can be selected as needed and have access to the restricted API when run with jake. 

The changes have been done by a script based on the jdeps output for every jtreg test.


Best regards,
Alexander


From yuri.nesterenko at oracle.com  Mon Jun 22 16:22:57 2015
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Mon, 22 Jun 2015 19:22:57 +0300
Subject: <Swing Dev> RFR: JDK-8076468 Add @modules to tests in
	jdk_desktop test group
In-Reply-To: <65abc491-66be-450e-b519-63e2bcbd258b@default>
References: <65abc491-66be-450e-b519-63e2bcbd258b@default>
Message-ID: <55883661.1040706@oracle.com>

Hi Alexander,

the fix looks OK to me.

Thanks,
-yan

On 06/22/2015 06:44 PM, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review the test-only changes for the JDK-8076468
>
> CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/
>
> @modules keywords have been added to the jtreg tests so that the tests can be selected as needed and have access to the restricted API when run with jake.
>
> The changes have been done by a script based on the jdeps output for every jtreg test.
>
>
> Best regards,
> Alexander
>



From philip.race at oracle.com  Mon Jun 22 21:20:54 2015
From: philip.race at oracle.com (Phil Race)
Date: Mon, 22 Jun 2015 14:20:54 -0700
Subject: <Swing Dev> [OpenJDK 2D-Dev] RFR: JDK-8076468 Add @modules to
 tests in jdk_desktop test group
In-Reply-To: <65abc491-66be-450e-b519-63e2bcbd258b@default>
References: <65abc491-66be-450e-b519-63e2bcbd258b@default>
Message-ID: <55887C36.9050308@oracle.com>

I guess I was expecting to see only tests that use internal API updated
but we do have some that do not being updated.

grep "@modules" jdk.patch | grep -v sun | more | wc
     119     455    3341

+ * @modules java.datatransfer
+ * @modules java.compiler
+ * @modules java.desktop

And this simple grep is not catching the "jdk.compiler" tag usage
nor printing out the multi-line cases such as
test/java/beans/PropertyEditor/TestBooleanClassJava.java
+ * @modules java.compiler
+ *          java.desktop
+ *          jdk.compiler

I can understand some of these - you are only putting "java.desktop"
into the test properties files. But why do I still see so many cases
where java.desktop is being listed without internal API usage ?

grep "java.desktop"  jdk.patch | grep -v sun | wc
      96     264    2445

Trying to answer my own question it appears to be that
the @modules" tag is "all or nothing" .. and that so
java.desktop needs to be listed when some other module
is listed. Is that correct ? If so then I'll give this an "OK"
but really this is the sort of reason that you ought to have
written here in the code review request so I don't have to
do a bunch of research and guessing just to review your change.

If you have sufficient reviewers *and* the answer to my questions
are as I suppose, then you can push to jdk9-client, and preferably
before 3 am PDT Tuesday (about 12 1/2 hours from now) so that
we can get this into the next PIT cycle.

-phil


On 06/22/2015 08:44 AM, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review the test-only changes for the JDK-8076468
>
> CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/
>
> @modules keywords have been added to the jtreg tests so that the tests can be selected as needed and have access to the restricted API when run with jake.
>
> The changes have been done by a script based on the jdeps output for every jtreg test.
>
>
> Best regards,
> Alexander



From Alan.Bateman at oracle.com  Tue Jun 23 06:58:16 2015
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Tue, 23 Jun 2015 07:58:16 +0100
Subject: <Swing Dev> RFR: JDK-8076468 Add @modules to tests in
	jdk_desktop test group
In-Reply-To: <65abc491-66be-450e-b519-63e2bcbd258b@default>
References: <65abc491-66be-450e-b519-63e2bcbd258b@default>
Message-ID: <55890388.2020106@oracle.com>

On 22/06/2015 16:44, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review the test-only changes for the JDK-8076468
>
> CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/
>
> @modules keywords have been added to the jtreg tests so that the tests can be selected as needed and have access to the restricted API when run with jake.
>
> The changes have been done by a script based on the jdeps output for every jtreg test.
>
I skimmed through the patch file and it looks okay to me. I can't 
validate that the dependences (and hence the @modules) are correct for 
each test but they seem right on a few spot checks.

As regards Phil's comments/questions then I think the most important 
thing is to have @modules on the tests that make use of non-exported 
APIs. In the future then using @modules for test selection would be 
useful too.

-Alan


From alexandr.scherbatiy at oracle.com  Tue Jun 23 08:25:19 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Tue, 23 Jun 2015 11:25:19 +0300
Subject: <Swing Dev> RFR: JDK-8076468 Add @modules to tests in
 jdk_desktop test group
In-Reply-To: <65abc491-66be-450e-b519-63e2bcbd258b@default>
References: <65abc491-66be-450e-b519-63e2bcbd258b@default>
Message-ID: <558917EF.7070709@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/22/2015 6:44 PM, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review the test-only changes for the JDK-8076468
>
> CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/
>
> @modules keywords have been added to the jtreg tests so that the tests can be selected as needed and have access to the restricted API when run with jake.
>
> The changes have been done by a script based on the jdeps output for every jtreg test.
>
>
> Best regards,
> Alexander



From joe.darcy at oracle.com  Wed Jun 24 23:42:46 2015
From: joe.darcy at oracle.com (joe darcy)
Date: Wed, 24 Jun 2015 16:42:46 -0700
Subject: <Swing Dev> JDK 9 RFR of JDK-8129822: Define "headful" jtreg keyword
Message-ID: <558B4076.2080008@oracle.com>

Hello,

To support the next iteration of tiered testing in JDK 9, with an eye 
toward running client library tests, please review the patch below which 
addresses

     JDK-8129822: Define "headful" jtreg keyword

Some test environments are headless, including test environments often 
used for the tier 1 and tier 2 tests. The jdk_desktop test group is 
defined as follows:

jdk_desktop = \
     :jdk_awt \
     :jdk_2d \
     :jdk_beans \
     :jdk_swing \
     :jdk_sound \
     :jdk_imageio

Of those constituent test groups, nearly all of the tests in jdk_beans, 
jdk_sound, and jdk_imageio can be successfully run in a *headless* 
environment. Therefore, I'd like to be able to tag the handful of tests 
that need a head with "@key headful"  so they can be excluded from test 
runs in a headless environment.

Future changesets will add the keyword to the appropriate tests.

Thanks,

-Joe

diff -r db09207cc779 test/TEST.ROOT
--- a/test/TEST.ROOT    Wed Jun 24 15:15:10 2015 -0700
+++ b/test/TEST.ROOT    Wed Jun 24 16:33:09 2015 -0700
@@ -8,8 +8,11 @@
  # would not count as "randomness" by this definition.) Extra care
  # should be taken to handle test failures of intermittent or
  # randomness tests.
+#
+# A "headful" test requires a graphical environment to meaningfully
+# run. Tests that are not headful are "headless."

-keys=2d dnd i18n intermittent randomness
+keys=2d dnd i18n intermittent randomness headful

  # Tests that must run in othervm mode
  othervm.dirs=java/awt java/beans javax/accessibility javax/imageio 
javax/sound javax/print javax/management com/sun/awt sun/awt sun/java2d 
sun/pisces javax/xml/jaxp/testng/validation java/lang/ProcessHandle



From joe.darcy at oracle.com  Wed Jun 24 23:47:18 2015
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 24 Jun 2015 16:47:18 -0700
Subject: <Swing Dev> JDK 9 RFR of JDK-8129822: Define "headful" jtreg
	keyword
In-Reply-To: <558B4076.2080008@oracle.com>
References: <558B4076.2080008@oracle.com>
Message-ID: <558B4186.1000204@oracle.com>

PS Discussion of the next iteration of tiered testing:

http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html

Thanks,

-Joe

On 6/24/2015 4:42 PM, joe darcy wrote:
> Hello,
>
> To support the next iteration of tiered testing in JDK 9, with an eye 
> toward running client library tests, please review the patch below 
> which addresses
>
>     JDK-8129822: Define "headful" jtreg keyword
>
> Some test environments are headless, including test environments often 
> used for the tier 1 and tier 2 tests. The jdk_desktop test group is 
> defined as follows:
>
> jdk_desktop = \
>     :jdk_awt \
>     :jdk_2d \
>     :jdk_beans \
>     :jdk_swing \
>     :jdk_sound \
>     :jdk_imageio
>
> Of those constituent test groups, nearly all of the tests in 
> jdk_beans, jdk_sound, and jdk_imageio can be successfully run in a 
> *headless* environment. Therefore, I'd like to be able to tag the 
> handful of tests that need a head with "@key headful"  so they can be 
> excluded from test runs in a headless environment.
>
> Future changesets will add the keyword to the appropriate tests.
>
> Thanks,
>
> -Joe
>
> diff -r db09207cc779 test/TEST.ROOT
> --- a/test/TEST.ROOT    Wed Jun 24 15:15:10 2015 -0700
> +++ b/test/TEST.ROOT    Wed Jun 24 16:33:09 2015 -0700
> @@ -8,8 +8,11 @@
>  # would not count as "randomness" by this definition.) Extra care
>  # should be taken to handle test failures of intermittent or
>  # randomness tests.
> +#
> +# A "headful" test requires a graphical environment to meaningfully
> +# run. Tests that are not headful are "headless."
>
> -keys=2d dnd i18n intermittent randomness
> +keys=2d dnd i18n intermittent randomness headful
>
>  # Tests that must run in othervm mode
>  othervm.dirs=java/awt java/beans javax/accessibility javax/imageio 
> javax/sound javax/print javax/management com/sun/awt sun/awt 
> sun/java2d sun/pisces javax/xml/jaxp/testng/validation 
> java/lang/ProcessHandle
>



From Alan.Bateman at oracle.com  Thu Jun 25 06:47:58 2015
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Thu, 25 Jun 2015 07:47:58 +0100
Subject: <Swing Dev> JDK 9 RFR of JDK-8129822: Define "headful" jtreg
	keyword
In-Reply-To: <558B4076.2080008@oracle.com>
References: <558B4076.2080008@oracle.com>
Message-ID: <558BA41E.2080109@oracle.com>



On 25/06/2015 00:42, joe darcy wrote:
> :
>
> diff -r db09207cc779 test/TEST.ROOT
> --- a/test/TEST.ROOT    Wed Jun 24 15:15:10 2015 -0700
> +++ b/test/TEST.ROOT    Wed Jun 24 16:33:09 2015 -0700
> @@ -8,8 +8,11 @@
>  # would not count as "randomness" by this definition.) Extra care
>  # should be taken to handle test failures of intermittent or
>  # randomness tests.
> +#
> +# A "headful" test requires a graphical environment to meaningfully
> +# run. Tests that are not headful are "headless."
>
> -keys=2d dnd i18n intermittent randomness
> +keys=2d dnd i18n intermittent randomness headful
Looks fine.


From alexandr.scherbatiy at oracle.com  Thu Jun 25 10:13:16 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 25 Jun 2015 13:13:16 +0300
Subject: <Swing Dev> JDK 9 RFR of JDK-8129822: Define "headful" jtreg
 keyword
In-Reply-To: <558B4076.2080008@oracle.com>
References: <558B4076.2080008@oracle.com>
Message-ID: <558BD43C.8060604@oracle.com>

On 6/25/2015 2:42 AM, joe darcy wrote:
> Hello,
>
> To support the next iteration of tiered testing in JDK 9, with an eye 
> toward running client library tests, please review the patch below 
> which addresses
>
>     JDK-8129822: Define "headful" jtreg keyword
>
> Some test environments are headless, including test environments often 
> used for the tier 1 and tier 2 tests. The jdk_desktop test group is 
> defined as follows:
>
> jdk_desktop = \
>     :jdk_awt \
>     :jdk_2d \
>     :jdk_beans \
>     :jdk_swing \
>     :jdk_sound \
>     :jdk_imageio
>
> Of those constituent test groups, nearly all of the tests in 
> jdk_beans, jdk_sound, and jdk_imageio can be successfully run in a 
> *headless* environment. Therefore, I'd like to be able to tag the 
> handful of tests that need a head with "@key headful"  so they can be 
> excluded from test runs in a headless environment.
>
> Future changesets will add the keyword to the appropriate tests.
>
> Thanks,
>
> -Joe
>
> diff -r db09207cc779 test/TEST.ROOT
> --- a/test/TEST.ROOT    Wed Jun 24 15:15:10 2015 -0700
> +++ b/test/TEST.ROOT    Wed Jun 24 16:33:09 2015 -0700
> @@ -8,8 +8,11 @@
>  # would not count as "randomness" by this definition.) Extra care
>  # should be taken to handle test failures of intermittent or
>  # randomness tests.
> +#
> +# A "headful" test requires a graphical environment to meaningfully
> +# run. Tests that are not headful are "headless."
>
> -keys=2d dnd i18n intermittent randomness
> +keys=2d dnd i18n intermittent randomness headful
>
>  # Tests that must run in othervm mode
>  othervm.dirs=java/awt java/beans javax/accessibility javax/imageio 
> javax/sound javax/print javax/management com/sun/awt sun/awt 
> sun/java2d sun/pisces javax/xml/jaxp/testng/validation 
> java/lang/ProcessHandle
>

  The fix looks good to me.

  Thanks,
  Alexandr.


From semyon.sadetsky at oracle.com  Thu Jun 25 14:27:32 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Thu, 25 Jun 2015 17:27:32 +0300
Subject: <Swing Dev> [9] Review Request for 8076164: [JTextField] When input
 too long Thai character, cursor's behavior is odd
Message-ID: <558C0FD4.5070609@oracle.com>

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8076164
webrev: http://cr.openjdk.java.net/~ssadetsky/8076164/webrev.00/

It is a regression from 6973777. In 6973777 GlyphView minimum span with 
calculation was changed to use text wrapping into several lines. That 
was necessary to fix several JTextPane scenarios. But this change did 
not preserve the generic rule: if resizing is disabled in 
getResizeWeight() then the preferred size should be used as the minimum. 
Since originally the GlyphView was not resizable the fix broke 
JTextFiled's I18N view because text wrapping is not applicable to it by 
design.
The solution restores the logic for JTextFiled's I18N content view.

--Semyon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20150625/49778c57/attachment.html>

From semyon.sadetsky at oracle.com  Fri Jun 26 10:48:15 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Fri, 26 Jun 2015 13:48:15 +0300
Subject: <Swing Dev> [9] Review Request for 8129830: JTree drag/drop on
 lower half of last child of container incorrect
Message-ID: <558D2DEF.3040202@oracle.com>

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8129830
webrev: http://cr.openjdk.java.net/~ssadetsky/8129830/webrev.00/

It is not possible to insert a tree node as a last child of any parent 
using Drag&Drop because the node is inserted as a sibling after the 
parent node.
To distinct those cases a solution is proposed: if drop point location 
is closer to the previous row then to insert into the last child 
position and insert into the sibling position otherwise.

--Semyon


From semyon.sadetsky at oracle.com  Fri Jun 26 13:22:22 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Fri, 26 Jun 2015 16:22:22 +0300
Subject: <Swing Dev> [9] Review Request for 8129940: JRadioButton does not
 honor non-standard FocusTraversalKeys
Message-ID: <558D520E.9000105@oracle.com>

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8129940
webrev: http://cr.openjdk.java.net/~ssadetsky/8129940/webrev.00/

It is a regression from 8033699. In this fix focus traversal keys were 
hard-coded in JRadioButton to be TAB and SHIFT+TAB only. But those keys 
can be amended by user as well. Solution : use the generic logic to 
identify focus traversal keys.

--Semyon


From semyon.sadetsky at oracle.com  Mon Jun 29 08:29:42 2015
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Mon, 29 Jun 2015 11:29:42 +0300
Subject: <Swing Dev> [9] Review Request for 8081484: [TEST_BUG]Test
 javax/swing/plaf/basic/6866751/bug6866751.java fails
Message-ID: <559101F6.6080202@oracle.com>

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8081484
webrev: http://cr.openjdk.java.net/~ssadetsky/8081484/webrev.00/

Frame need to be re-layouted after the caret with changed.

--Semyon


From Sergey.Bylokhov at oracle.com  Mon Jun 29 09:16:01 2015
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 29 Jun 2015 12:16:01 +0300
Subject: <Swing Dev> [9] Review Request for 8081484: [TEST_BUG]Test
 javax/swing/plaf/basic/6866751/bug6866751.java fails
In-Reply-To: <559101F6.6080202@oracle.com>
References: <559101F6.6080202@oracle.com>
Message-ID: <55910CD1.70600@oracle.com>

The fix looks fine.

On 29.06.15 11:29, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8081484
> webrev: http://cr.openjdk.java.net/~ssadetsky/8081484/webrev.00/
>
> Frame need to be re-layouted after the caret with changed.
>
> --Semyon


-- 
Best regards, Sergey.



From alexander.zvegintsev at oracle.com  Tue Jun 30 11:31:59 2015
From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev)
Date: Tue, 30 Jun 2015 14:31:59 +0300
Subject: <Swing Dev> [9] Review Request for 8129830: JTree drag/drop on
 lower half of last child of container incorrect
In-Reply-To: <558D2DEF.3040202@oracle.com>
References: <558D2DEF.3040202@oracle.com>
Message-ID: <55927E2F.6050206@oracle.com>

Hello Semyon,

the fix looks good to me.

Thanks,
Alexander.

On 26/06/15 13:48, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8129830
> webrev: http://cr.openjdk.java.net/~ssadetsky/8129830/webrev.00/
>
> It is not possible to insert a tree node as a last child of any parent 
> using Drag&Drop because the node is inserted as a sibling after the 
> parent node.
> To distinct those cases a solution is proposed: if drop point location 
> is closer to the previous row then to insert into the last child 
> position and insert into the sibling position otherwise.
>
> --Semyon



From alexander.zvegintsev at oracle.com  Tue Jun 30 11:32:40 2015
From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev)
Date: Tue, 30 Jun 2015 14:32:40 +0300
Subject: <Swing Dev> [9] Review Request for 8081484: [TEST_BUG]Test
 javax/swing/plaf/basic/6866751/bug6866751.java fails
In-Reply-To: <55910CD1.70600@oracle.com>
References: <559101F6.6080202@oracle.com> <55910CD1.70600@oracle.com>
Message-ID: <55927E58.6090509@oracle.com>

looks fine to me too.

Thanks,
Alexander.

On 29/06/15 12:16, Sergey Bylokhov wrote:
> The fix looks fine.
>
> On 29.06.15 11:29, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8081484
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8081484/webrev.00/
>>
>> Frame need to be re-layouted after the caret with changed.
>>
>> --Semyon
>
>



From alexandr.scherbatiy at oracle.com  Tue Jun 30 13:24:47 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Tue, 30 Jun 2015 16:24:47 +0300
Subject: <Swing Dev> [9] Review Request for 8076164: [JTextField] When
 input too long Thai character, cursor's behavior is odd
In-Reply-To: <558C0FD4.5070609@oracle.com>
References: <558C0FD4.5070609@oracle.com>
Message-ID: <5592989F.2080909@oracle.com>


   The fix looks good to me.

   Just update the copyright in the test, use Swing component on EDT and 
format the code.

   Thanks,
   Alexandr.

On 6/25/2015 5:27 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8076164
> webrev: http://cr.openjdk.java.net/~ssadetsky/8076164/webrev.00/
>
> It is a regression from 6973777. In 6973777 GlyphView minimum span 
> with calculation was changed to use text wrapping into several lines. 
> That was necessary to fix several JTextPane scenarios. But this change 
> did not preserve the generic rule: if resizing is disabled in 
> getResizeWeight() then the preferred size should be used as the 
> minimum. Since originally the GlyphView was not resizable the fix 
> broke JTextFiled's I18N view because text wrapping is not applicable 
> to it by design.
> The solution restores the logic for JTextFiled's I18N content view.
>
> --Semyon
>



From alexandr.scherbatiy at oracle.com  Tue Jun 30 14:35:34 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Tue, 30 Jun 2015 17:35:34 +0300
Subject: <Swing Dev> [9] Review Request for 8129830: JTree drag/drop on
 lower half of last child of container incorrect
In-Reply-To: <55927E2F.6050206@oracle.com>
References: <558D2DEF.3040202@oracle.com> <55927E2F.6050206@oracle.com>
Message-ID: <5592A936.508@oracle.com>



The fix looks good to me.

Thanks,
Alexandr.


On 6/30/2015 2:31 PM, Alexander Zvegintsev wrote:
> Hello Semyon,
>
> the fix looks good to me.
>
> Thanks,
> Alexander.
>
> On 26/06/15 13:48, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8129830
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8129830/webrev.00/
>>
>> It is not possible to insert a tree node as a last child of any 
>> parent using Drag&Drop because the node is inserted as a sibling 
>> after the parent node.
>> To distinct those cases a solution is proposed: if drop point 
>> location is closer to the previous row then to insert into the last 
>> child position and insert into the sibling position otherwise.
>>
>> --Semyon
>