<Swing Dev> [9] Review request for 8072900: Mouse events are captured by the wrong menu in OS X
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Thu Mar 5 17:26:29 UTC 2015
Hi, Anton.
Thanks! The fix looks good.
On 05.03.2015 20:19, Anton Nashatyrev wrote:
> Hi Sergey,
>
> thanks for review!
>
> I've fixed the test as you suggested (renamed, using Robot, test
> for all LAFs). Please take a look ta the new version:
>
> http://cr.openjdk.java.net/~anashaty/8072900/9/webrev.01/
> <http://cr.openjdk.java.net/%7Eanashaty/8072900/9/webrev.01/>
>
> Thanks!
> Anton.
>
> On 05.03.2015 19:21, Sergey Bylokhov wrote:
>> Hi, Anton.
>> The fix looks fine, but please use Robot.waitForIdle() instead of
>> realSync. Because SunToolkit will not be available for such tests in
>> jdk9 soon. I suppose test name can be changed too, but it is not
>> important.
>>
>> On 04.03.2015 17:44, Anton Nashatyrev wrote:
>>> Hello,
>>> could you please review the following fix:
>>>
>>> fix: http://cr.openjdk.java.net/~anashaty/8072900/9/webrev.00/
>>> <http://cr.openjdk.java.net/%7Eanashaty/8072900/9/webrev.00/>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8072900
>>>
>>> The problem: On MacOS if there are two frames with menu, the first
>>> is opened and the mouse moved over the second it causes the second
>>> menu to be opened.
>>>
>>> The reason: the AquaMenuUI creates its own MouseHandler and the
>>> logic of mouseEnter() has not been completely ported from the
>>> BasicMenuUI.
>>>
>>> Thanks!
>>> Anton.
>>
>>
>
--
Best regards, Sergey.
More information about the swing-dev
mailing list