<Swing Dev> [9] Review Request for 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end of the line.

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Mar 23 14:41:27 UTC 2015


Hi, Semyon.
It seems that "Caret.width" is platform specific property, right? (looks 
like it is initialized on windows only). What happens if the user will 
set the size/aspect of the caret via "putClientProperty" after the fix? 
It seems that correct width of the caret can be obtained via 
DefaultCaret.getCaretWidth (It takes into account both  properties: 
aspectRatio/caretWidth). Probably we can push implementation of this 
method to the Caret class itself(in jdk9) or at least share the code 
somehow? Note that we can initialize caretWidth for each L&F by default 
to 1(or to Caret.width) if this value is correct, so the user will be 
able take current value which is used by Swing.

23.03.15 14:57, Semyon Sadetsky wrote:
> +description
> Cursor size is added to any text control preferred width.
>
> On 3/23/2015 2:33 PM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review JDK9 fix.
>>
>> webrev: 
>> http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6866751/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-6866751
>>
>> Thanks!
>> --Semyon
>


-- 
Best regards, Sergey.




More information about the swing-dev mailing list