<Swing Dev> JDK 9 RFR of JDK-8076286: Fix missing doclint warnings in javax.swing.{colorchooser, event, filechooser}
joe darcy
joe.darcy at oracle.com
Tue Mar 31 03:41:37 UTC 2015
Hello,
Please review this straightforward change to address
JDK-8076286: Fix missing doclint warnings in
javax.swing.{colorchooser, event, filechooser}
Patch below.
Thanks,
-Joe
---
old/src/java.desktop/share/classes/javax/swing/colorchooser/ColorChooserComponentFactory.java
2015-03-30 20:31:33.515167963 -0700
+++
new/src/java.desktop/share/classes/javax/swing/colorchooser/ColorChooserComponentFactory.java
2015-03-30 20:31:33.359089959 -0700
@@ -48,6 +48,10 @@
private ColorChooserComponentFactory() { } // can't instantiate
+ /**
+ * Returns the default chooser panels.
+ * @return the default chooser panels
+ */
public static AbstractColorChooserPanel[] getDefaultChooserPanels() {
return new AbstractColorChooserPanel[] {
new DefaultSwatchChooserPanel(),
@@ -58,6 +62,10 @@
};
}
+ /**
+ * Returns the preview panel.
+ * @return the preview panel
+ */
public static JComponent getPreviewPanel() {
return new DefaultPreviewPanel();
}
---
old/src/java.desktop/share/classes/javax/swing/colorchooser/DefaultColorSelectionModel.java
2015-03-30 20:31:33.955387977 -0700
+++
new/src/java.desktop/share/classes/javax/swing/colorchooser/DefaultColorSelectionModel.java
2015-03-30 20:31:33.799309972 -0700
@@ -47,6 +47,9 @@
*/
protected transient ChangeEvent changeEvent = null;
+ /**
+ * The listener list.
+ */
protected EventListenerList listenerList = new EventListenerList();
private Color selectedColor;
---
old/src/java.desktop/share/classes/javax/swing/event/EventListenerList.java
2015-03-30 20:31:34.399609991 -0700
+++
new/src/java.desktop/share/classes/javax/swing/event/EventListenerList.java
2015-03-30 20:31:34.247533986 -0700
@@ -101,7 +101,7 @@
public class EventListenerList implements Serializable {
/* A null array to be shared by all empty listener lists*/
private final static Object[] NULL_ARRAY = new Object[0];
- /* The list of ListenerType - Listener pairs */
+ /** The list of ListenerType - Listener pairs */
protected transient Object[] listenerList = NULL_ARRAY;
/**
---
old/src/java.desktop/share/classes/javax/swing/event/TableModelEvent.java 2015-03-30
20:31:34.827824005 -0700
+++
new/src/java.desktop/share/classes/javax/swing/event/TableModelEvent.java 2015-03-30
20:31:34.675748000 -0700
@@ -85,9 +85,21 @@
// Instance Variables
//
+ /**
+ * The type of the event.
+ */
protected int type;
+ /**
+ * The first row that has changed.
+ */
protected int firstRow;
+ /**
+ * The last row that has changed.
+ */
protected int lastRow;
+ /**
+ * The column for the event.
+ */
protected int column;
//
---
old/src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
2015-03-30 20:31:35.272046018 -0700
+++
new/src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
2015-03-30 20:31:35.107964013 -0700
@@ -73,6 +73,10 @@
private boolean useSystemExtensionHiding =
UIManager.getDefaults().getBoolean("FileChooser.useSystemExtensionHiding");
+ /**
+ * Returns the file system view.
+ * @return the file system view
+ */
public static FileSystemView getFileSystemView() {
if(File.separatorChar == '\\') {
if(windowsFileSystemView == null) {
@@ -101,6 +105,9 @@
return genericFileSystemView;
}
+ /**
+ * Constructs a FileSystemView.
+ */
public FileSystemView() {
final WeakReference<FileSystemView> weakReference = new
WeakReference<FileSystemView>(this);
@@ -424,6 +431,10 @@
// code. If a given OS can't, override these methods in its
// implementation.
+ /**
+ * Returns the home directory.
+ * @return the home directory
+ */
public File getHomeDirectory() {
return createFileObject(System.getProperty("user.home"));
}
More information about the swing-dev
mailing list