<Swing Dev> [9] Review Request for 6260348: GTK+ L&F JTextComponent not respecting desktop caret blink rate

[Semyon Sadetsky]

Hi Alexander,

gboolean and gint are equivalent.

--Semyon

On 4/27/2015 5:31 PM, Alexander Scherbatiy wrote:
> On 4/23/2015 5:23 PM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> web rev: http://cr.openjdk.java.net/~ssadetsky/6260348/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-6260348
>
> gtk2_interface.c
> 2510     gint intval = NULL;
> 2511     (*fp_g_object_get)(settings, key, &intval, NULL);
> 2512     return create_Boolean(env, intval);
>
> Probably the type of the value should be gboolean.
>
>  Thanks,
>  Alexandr.
>
>>
>> ***ROOT CAUSE
>> GTK L&F never took care about native GTK cursor blink settings.
>>
>> ***SOLUTION
>> Implement this feature.
>>
>> ***TESTING
>> Two test scenarios added. 1st sets GTK cursor blink enabled and blink 
>> time 200 ms. 2nd disables cursor blinking. Then Java text caret is 
>> checked to respect these settings.
>>
>> --Semyon
>>
>>
>