<Swing Dev> [9] Review Request for 6260348: GTK+ L&F JTextComponent not respecting desktop caret blink rate

[Alexander Zvegintsev]

Hi Semyon,

the fix itself looks good to me, but the test doesn't work.

1. FileWriter is replacing the .gtkrc-2.0 file (FileWriter(file, true 
/*append*/) should be used) ;
2. settings from .gtkrc-2.0  doesn't taken into account on my system.
there are at least two system tools which allows to modify such values:
gconftool-2 and gsettings. One of them may lack on different systems.
this will make test complicated.
So I suggest just remove the test and add noreg-hard label to the issue.

--
Thanks,
Alexander.

On 23.04.2015 17:23, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> web rev: http://cr.openjdk.java.net/~ssadetsky/6260348/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-6260348
>
> ***ROOT CAUSE
> GTK L&F never took care about native GTK cursor blink settings.
>
> ***SOLUTION
> Implement this feature.
>
> ***TESTING
> Two test scenarios added. 1st sets GTK cursor blink enabled and blink 
> time 200 ms. 2nd disables cursor blinking. Then Java text caret is 
> checked to respect these settings.
>
> --Semyon
>
>