<Swing Dev> [9] Review Request: 5109918 Wrong documentation for JSpinner.DateEditor constructor

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed May 13 15:30:08 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 5/12/2015 1:23 PM, Alexander Zvegintsev wrote:
> Hello Sergey,
>
> the fix looks fine.
>
> Thanks,
>
> Alexander.
>
> On 05/09/2015 02:50 AM, Sergey Bylokhov wrote:
>> Hello.
>> Please review one more small fix for a typo in jdk9.
>>
>> "Description for constructor "public JSpinner.DateEditor(JSpinner 
>> spinner)" containes:
>>      "This DateEditor becomes both a ChangeListener on the spinners 
>> model
>>       and a PropertyChangeListener on the new JFormattedTextField."
>> In fact DateEditor becomes a ChangeListener on the spinner but not on 
>> the spinners model"
>>
>> All other constructors except this one were fixed already in 
>> https://bugs.openjdk.java.net/browse/JDK-4408581
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-5109918
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/5109918/webrev.00
>>
>




More information about the swing-dev mailing list