<Swing Dev> [9] Review request for 8080628: No mnemonics on Open and Save buttons in JFileChooser
Alexander Scherbatiy
alexandr.scherbatiy at oracle.com
Thu May 21 12:15:58 UTC 2015
The fix looks good to me.
Thanks,
Alexandr.
On 5/21/2015 3:10 PM, Alexey Ivanov wrote:
> Hello Swing team,
>
> Could you please review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-8080628
> webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk9/webrev.00/
>
> Description:
> Since Open and Save buttons in JFileChooser are default ones,
> mnemonics are redundant on these buttons.
>
> There's no mnemonic on Open and Save buttons in Metal Look-and-Feel
> but it's displayed on Open button when a directory is selected in the
> file list. This is inconsistent.
>
> The fix:
> Remove mnemonics in JFileChooser from basic.properties which is used
> as the base for translation updates.
> Remove separate JFileChooser keys from metal.properties since they're
> the same as in basic.properties now.
>
> The test:
> Regression test checks Open, Save, and Cancel buttons in JFileChooser
> have no mnemonics in all the supported localizations in Metal and
> Nimbus look-and-feels.
>
> Thanks,
> Alexey
More information about the swing-dev
mailing list