<Swing Dev> [9] Review request for 8080628: No mnemonics on Open and Save buttons in JFileChooser

[Sergey Bylokhov]

Hi, Alexey.
If is obvious that all others l&f should work, then I do not see the 
reason why we cannot test them.

On 21.05.15 15:37, Alexey Ivanov wrote:
> Hi Sergey,
>
> Because other look-and-feels do not define their own resources.
> Actually, one LaF would be enough, if Metal did not define its own 
> Open and Save without mnemonics.
>
> I can modify the test to iterate over all the installed LaFs. I just 
> thought it was enough to use these two because either is available on 
> all the platforms, and eventually all LaFs read the values from 
> basic.properties after the fix.
>
> Regards,
> Alexey
>
> On 21.05.2015 15:28, Sergey Bylokhov wrote:
>> Hi, Alexey.
>> Why only two look and fells are covered(metal/nimbus)?
>>
>> On 21.05.15 15:10, Alexey Ivanov wrote:
>>> Hello Swing team,
>>>
>>> Could you please review the fix:
>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8080628
>>>     webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk9/webrev.00/
>>>
>>> Description:
>>> Since Open and Save buttons in JFileChooser are default ones, 
>>> mnemonics are redundant on these buttons.
>>>
>>> There's no mnemonic on Open and Save buttons in Metal Look-and-Feel 
>>> but it's displayed on Open button when a directory is selected in 
>>> the file list. This is inconsistent.
>>>
>>> The fix:
>>> Remove mnemonics in JFileChooser from basic.properties which is used 
>>> as the base for translation updates.
>>> Remove separate JFileChooser keys from metal.properties since 
>>> they're the same as in basic.properties now.
>>>
>>> The test:
>>> Regression test checks Open, Save, and Cancel buttons in 
>>> JFileChooser have no mnemonics in all the supported localizations in 
>>> Metal and Nimbus look-and-feels.
>>>
>>> Thanks,
>>> Alexey
>>
>>
>


-- 
Best regards, Sergey.