<Swing Dev> [9] Review Request for 8140527: JInternalFrame has incorrect title button width

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Nov 6 13:39:20 UTC 2015


On 10/28/2015 12:54 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8140527
> webrev: http://cr.openjdk.java.net/~ssadetsky/8140527/webrev.00/
>
> Title buttons under Widows Classic LnF got their sizes from the XP 
> desktop theme in which button width can be bigger than height. The 
> proposed fix forces title buttons to be square and to fit the frame 
> title in height.

    It looks like the "InternalFrame.titleButtonWidth" property can be 
set by a user in UIManager. Should not the updated width value be used 
in this case instead of the height property?

   The test uses internal OSInfo class. The appropriate @modules tag 
should be done in this case for the jake build.

  Thanks,
  Alexandr.





More information about the swing-dev mailing list