<Swing Dev> Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

[Rajeev Chamyal]

Hello,

Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8079253/webrev.01/

Removed the line JFrame.setDefaultLookAndFeelDecorated as Frame size issue will be fixed once JDK-8073710 is resolved.
Updated the bug description for JDK-8079253.

Regards,
Rajeev Chamyal

-----Original Message-----
From: Alexander Scherbatiy 
Sent: 06 November 2015 15:58
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev at openjdk.java.net
Subject: Re: Review request for JDK-8079253 Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

On 11/6/2015 1:21 PM, Rajeev Chamyal wrote:
> Hello Alexander,
>
> Thanks for the review.
> We need to set the opaque property on the label as well.

    I see.

    The idea is that we do not fix tests itself so they just work. The tests are necessary to find as much issues as possible.
    If this test requires that the JDK-8073710 would be fixed first we need to leave it and wait for the JDK-8073710 fix.

    The issue the the opaque property can be added as a comment to the
JDK-8073710 bug so it will be updated with the JDK-8073710 fix.

    Thanks,
    Alexandr.

>
> Regards,
> Rajeev Chamyal
>
> -----Original Message-----
> From: Alexander Scherbatiy
> Sent: 06 November 2015 15:39
> To: Rajeev Chamyal
> Cc: Sergey Bylokhov; swing-dev at openjdk.java.net
> Subject: Re: Review request for JDK-8079253 Test 
> javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails
>
> On 11/6/2015 12:38 PM, Rajeev Chamyal wrote:
>> Hello All,
>>
>> Please review the following fix for Jdk9:
>>    
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8079253
>>
>> Webrev:http://cr.openjdk.java.net/~rchamyal/8079253/webrev.00/
>> <http://cr.openjdk.java.net/%7Erchamyal/8079253/webrev.00/>
>>
>> Issue: The test case shortens two text labels and writes the 
>> resulting same strings to buffered images.
>>
>> On Ubuntu linux the image pixels are not matching.
>>
>>    
>> Cause: The frame size in Ubuntu is coming different every time which is resulting in different size images and resulting into issue.
>> BugJDK-8073710  <https://bugs.openjdk.java.net/browse/JDK-8073710>  is already reported for this issue.
>> Also we need set the opaque property on label component which makes sure that all of the bits contained within component's rectangular bounds are painted.
> Should the original test (without the proposed changes) work if
> JDK-8073710 is fixed?
> If yes, the current issue should be closed as duplicate of the JDK-8073710.
>
> Thanks,
> Alexandr.
>>    
>> Fix: Setting the default look and feel decoration for frame size issue and making label opaque.
>>    
>> Regards,
>> Rajeev Chamyal
>>