<Swing Dev> Review request for 8133039 Provide public API to sun.swing.UIAction#isEnabled(Object)

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Nov 11 13:22:53 UTC 2015


On 11/10/2015 3:10 PM, Andrej Golovnin wrote:
> Hi Alexander,
>
> you patch changes the signature of a public method in SwingUtilities:
>
> Current JDK
> 1731     public static boolean notifyAction(Action action, KeyStroke ks,
> 1732                                        KeyEvent event, Object sender,
>
> After your change:
>
> 1731     public static boolean notifyAction(Action action, KeyStroke ks,
> 1732                                        KeyEvent event, JComponent sender,
>
> Don't you think it may break binary compatibility? The method exists
> since JDK 1.3.

    You are right.

   There is the updated fix there the sender type is Object:
     http://cr.openjdk.java.net/~alexsch/8133039/webrev.01

   Thanks,
   Alexandr.
>
> Best regards,
> Andrej Golovnin




More information about the swing-dev mailing list