<Swing Dev> [9] Review Request for 8139215: RTFEditorKit does not save alignment

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Oct 21 11:07:20 UTC 2015


On 10/20/2015 6:56 PM, Semyon Sadetsky wrote:
>
>
> On 10/16/2015 12:49 PM, Alexander Scherbatiy wrote:
>>
>> RTFAttributes class contains RTF control words for alignment (ql, qr) 
>> as well as others (b, i, ul, ...).
>> What is the reason that RTFGenerator does not treat alignment control 
>> words in the same way as others?
> Agree. It should use the existing RTF attribute set. The RTFGenerator 
> did not work correctly with assertive attributes. That was the root cause.
> The updated fix: http://cr.openjdk.java.net/~ssadetsky/8139215/webrev.01/

    The fix looks good to me.

   Thanks,
   Alexandr.

>>
>> Thanks,
>> Alexandr.
>>
>> On 10/13/2015 8:41 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8139215
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8139215/webrev.00/
>>>
>>> RTFEditorKit's writer functionality is limited and doesn't support 
>>> writing of rtf paragraphs alignment. The proposed fix introduces 
>>> support for the rtf paragraph alignment.
>>>
>>> --Semyon
>>>
>>
>




More information about the swing-dev mailing list