<Swing Dev> [9] Review Request for 8133108: [PIT] Container size is wrong in JEditorPane

Semyon Sadetsky semyon.sadetsky at oracle.com
Thu Sep 3 13:08:32 UTC 2015


Hello,

I have reworked the fix because more regressions was found.
Please look at the updated version:
http://cr.openjdk.java.net/~ssadetsky/8133108/webrev.02/

--Semyon


On 8/10/2015 5:39 PM, Alexander Scherbatiy wrote:
> On 8/6/2015 7:46 PM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8133108
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8133108/webrev.01/
>
>   Could you look at the test 
> javax/swing/JTextPane/JTextPaneDocumentAlignment.java
>   It fails on my system with the suggested fix.
>
>   Thanks,
>   Alexandr.
>
>>
>> This a regression from JDK-8132136 after which the GlyphView does not 
>> wrap text for the minimum width calculation by default anymore. 
>> InlineView as GlyphView descendant should take care about setting the 
>> right resize weight now. In the solution getResizeWeight() is 
>> overridden in InlineView to return the right weight according to the 
>> nowrap field.
>> Test suite is added to check the right text positioning for 
>> wrap/nowrap styles in the JTextPane document.
>>
>> --Semyon
>




More information about the swing-dev mailing list