<Swing Dev> [9-client] Review request for bug 8005914: [TEST_BUG] The last column header does not contain "..."

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Sep 3 14:42:28 UTC 2015


On 9/3/2015 8:52 AM, shilpi rastogi wrote:
> Hi all,
>
> Please review a test bug fix
>
> Test - closed/javax/swing/JTableHeader/6442918/bug6442918a.java
> Bug Link-  https://bugs.openjdk.java.net/browse/JDK-8005914
>
> Please remove  the test from closed repo to open repo.
>
> open: 
> http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev-8005914/open%208005914/webrev/ 
>
> closed: 
> http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev-8005914/closed%208005914/webrev/ 
>

    It is better to create static createModalDialogWithPassFailButtons 
method in Util class which returns the modal dialog.
    In this case it is not necessary to have pass() and waitTestResult() 
methods because the modal dialog blocks the EDT.
    The invokeLater() method can be changed to invokeAndWait() in this 
case.

   Thanks,
   Alexandr.

>
> Thanks,
> Shilpi
>
>
>




More information about the swing-dev mailing list