<Swing Dev> [9] Review Request: 8134947 [macosx] Various memory leaks in Aqua look and feel

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Sep 7 12:48:16 UTC 2015


Hello.
Please review the fix for jdk9.
Initially I found this bug in JSpinner during my work on
JDK-7124397, after I covers other components in the test I found other 
cases in Aqua.

The problem is that some of UI delegates in Aqua does not follow the 
rules that they should removes all listeners/references in the 
uninstallUI method.

AquaCaret.java + related textui : this ui now updates the 
reference/listeners in install/deinstall instead of update it only once 
in the constructor.

AquaInternalFrameUI.java : code related to components removing was moved 
to uninstallComponents.

AquaSpinnerUI.java : see comments in the code.

AquaTabbedPaneUI.java : I force removing of the reference to the ui 
delegate from the timer.

I also tried to make a small cleanup and split longest lines only, 
otherwise in some cases I will have to update the whole files.

The follow bug for motif/synth l&f is filed: JDK-8135138

Bug: https://bugs.openjdk.java.net/browse/JDK-8134947
The new test: http://cr.openjdk.java.net/~serb/8134947/webrev.00
-- 
Best regards, Sergey.



More information about the swing-dev mailing list