<Swing Dev> [9] Review Request for 8134828: Scrollbar thumb disappears with Nimbus L&F

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Sep 10 12:55:17 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 9/8/2015 11:57 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
> bug: https://bugs.openjdk.java.net/browse/JDK-8134828
> webrev: http://cr.openjdk.java.net/~ssadetsky/8134828/webrev.00/
>
> This is a regression from the 8041642 which introduced a protection 
> from shrinking of the painter image less then it stretching inset when 
> 9-square algorithm is applied to it. But the scroll bar has minimum 
> thumb size 29px while its stretching inset is 30px and it allows 
> painter image to be shrunk from 30px to 29px. So the painter image 
> shrinking is determined by the component type.
> As a solution the 8041642 fix was reworked to disable shrinking for 
> the progress bar component only. To regulate this the new properties 
> were introduced in the Nimbus default style: minBarSize and glowWidth. 
> The last one fix yet another issue with the progress bar in Nimbus: 
> the bar foreground alignment ignored the transparent glow in the 
> painter image for the inverted progress bar direction.
>
> --Semyon




More information about the swing-dev mailing list