<Swing Dev> [9] Review Request for 8133864: Wrong display, when the document I18n properties is true.

[Alexander Scherbatiy]

On 9/9/2015 3:43 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
> bug: https://bugs.openjdk.java.net/browse/JDK-8133864
> webrev: http://cr.openjdk.java.net/~ssadetsky/8133864/webrev.00/
>
> For the i18n mode the TextLayoutStrategy reorders child views in 
> paragraph's row according to the bidi leveles. To reorder the 
> CompositeView.replace() method is called which contains the same views 
> but in different order. The replace() method has an issue because it 
> can damage inner hierarchy of the child view by setting its parent to 
> null.
> The fix solution introduces a check if a view item is in use before 
> nullifying its parent.

    Would it be faster to use HashSet instead of a list for the 
contains() method?

   Thanks,
   Alexandr.

>
> --Semyon