<Swing Dev> [9] Review Request for 8133803: Swing JFileChooserBug2 test fais with MotifLookAndFeel

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Sep 15 15:28:51 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 9/14/2015 1:14 PM, Semyon Sadetsky wrote:
> Yes. It also need to be restricted.
> http://cr.openjdk.java.net/~ssadetsky/8133803/webrev.01/
> --Semyon
>
> On 9/11/2015 5:49 PM, Alexander Scherbatiy wrote:
>>
>>   The MotifFileChooserUI contains two text fields. Should another 
>> text filed be updated in the same way?
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 9/7/2015 4:23 PM, Semyon Sadetsky wrote:
>>> ??? It determines its size.
>>>
>>> On 9/7/2015 2:58 PM, Alexander Scherbatiy wrote:
>>>> On 9/4/2015 9:03 PM, Semyon Sadetsky wrote:
>>>>> Because it fits the width and it is the same in the Metal L&F 
>>>>> which passes the test.
>>>>
>>>>    Is it possible to calculate the text field columns number based 
>>>> on the file chooser size?
>>>>
>>>>    Thanks,
>>>>    Alexandr.
>>>>>
>>>>> --Semyon
>>>>>
>>>>> On 9/4/2015 6:18 PM, Sergey Bylokhov wrote:
>>>>>> Simple question: why 35?
>>>>>>
>>>>>> On 04.09.15 18:09, Semyon Sadetsky wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Please review fix for JDK9:
>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8133803
>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8133803/webrev.00/
>>>>>>>
>>>>>>> The width of the file selection text field was not limited under 
>>>>>>> Motif L&F.
>>>>>>>
>>>>>>> --Semyon
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>




More information about the swing-dev mailing list