<Swing Dev> [9] Review Request for 8062525: JInternalFrame can't show correctly with the specical option "-esa -ea -Xcheck:jni -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel".

[Sergey Bylokhov]

On 24.09.15 17:28, Semyon Sadetsky wrote:
>
>
> On 9/24/2015 4:56 PM, Alexander Scherbatiy wrote:
>>
>>   Does a component from a SynthContext always has a parent and a
>> parent of the parent?
> yes. It is the same usage as in the paintButtonBackground() method which
> calls updateFrameGeometry().

It is the similar, but the paintButtonBackground has no an assertion and 
simply returns if the titlePaneParent is not a JInternalFrame or 
JInternalFrame.JDesktopIcon, which means that you cannot simply cast the 
parent of the component to the JInternalFrame in the updateFrameGeometry.

But paintFrameBorder for example has an assertion. I think it will be 
good to cleanup this methods a little bit. At lest this sequence of 
similar instanceof inside and outside updateFrameGeometry is strange.

>>
>> On 9/21/2015 2:33 PM, Semyon Sadetsky wrote:
>>>
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8062525
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8062525/webrev.00/
>>>
>>> In the type check of the updateFrameGeometry() method the internal frame
>>> title buttons was not taken into account.
>>>
>>> --Semyon
>>>
>>>
>>>
>>
>


-- 
Best regards, Sergey.