<Swing Dev> Review request for 6949414 JMenu.buildMenuElementArray() endless loop

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Apr 4 14:15:43 UTC 2016


The fix looks fine.
(Probably the loop can be changed from the "while(true)" to iteration 
over MenuElement, but it is up2you)

On 04.04.16 15:38, Alexander Scherbatiy wrote:
>
> Hello,
>
> Could you review the fix:
>    bug: https://bugs.openjdk.java.net/browse/JDK-6949414
>    webrev: http://cr.openjdk.java.net/~alexsch/6949414/webrev.00
>
>    The endless loop in JMenu.buildMenuElementArray() method that
> JPopupMenu can be created without JMenuBar is fixed.
>    NPE that JPopupMenu does not necessary have ancestor window is fixed.
>
>
> Thanks,
> Alexandr.
>


-- 
Best regards, Sergey.



More information about the swing-dev mailing list