<Swing Dev> RfR: JDK-8153153, Format string argument mismatch in jaccesswalker.cpp:545

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Apr 5 14:14:33 UTC 2016


On 05.04.16 0:57, Phil Race wrote:
> The bug is now evaluated and jPRT is happy so "+1"

+1

>
> -phil.
>
> On 04/04/2016 03:00 PM, Pete Brunet wrote:
>> Evaluation added.
>>
>> Is the patch OK?
>>
>> https://bugs.openjdk.java.net/browse/JDK-8153153
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8153153/webrev.00/
>>
>> Pete
>>
>>
>> On 4/4/16 12:10 PM, Phil Race wrote:
>>> All bugs should have an evaluation. Period.
>>>
>>> -phil.
>>>
>>> On 04/04/2016 06:33 AM, Pete Brunet wrote:
>>>> Hi Phil, As far as I know this doesn't need an evaluation.  It's just a
>>>> printf arg mismatch so a 64 bit pointer only gets printed as a 32 bit
>>>> value, i.e. %X was used where %p should have been used.  It's something
>>>> I fixed in a lot of other places but this is one I missed.  All 7 JPRT
>>>> targets build OK.
>>>>
>>>> Pete
>>>>
>>>> On 4/2/16 10:58 AM, Philip Race wrote:
>>>>> I notice the bug has no evaluation. Unevaluated bugs aren't ready for
>>>>> review.
>>>>> Also did you run this through jprt ? If this causes a warning on some
>>>>> other
>>>>> platform than you tried you will break the build.
>>>>>
>>>>> -phil.
>>>>>
>>>>> On 4/1/16, 11:56 AM, Pete Brunet wrote:
>>>>>> Please review this simple fix:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8153153
>>>>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8153153/webrev.00/
>


-- 
Best regards, Sergey.



More information about the swing-dev mailing list